chore(tests): Re add fixed sources::file::tests::remove_file test
#4165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't check if the test is fixed if it isn't even run, so #4251 needs to be done first. |
ktff
added
the
meta: blocked
|
Blocked by #4196 |
|
@ktff Can this be merged? I am not following the link to the OSX tests? |
|
@jamtur01 this test was removed because it was flaky on mac, and with the OSX check being flaky, it would be more difficult to verify that the test was fixed now than to wait for the the linked issue to be resolved, although it is possible. There is also an alternative to disable this test for mac and enable it for the rest of OS. |
|
Let's disable it for OSX and run for everything else. Add a TODO to fix this once the OSX test issue is resolved. |
Signed-off-by: ktf <[email protected]>
Signed-off-by: ktf <[email protected]>
ktff
force-pushed
the
ktff/readd_remove_file_test
branch
from
3644684 to
454ba6d
Compare
Signed-off-by: ktf <[email protected]>
ktff
removed
the
meta: blocked
fanatid
approved these changes
Oct 18, 2020
juchiast
pushed a commit
that referenced
this pull request
Oct 19, 2020
…4165) * Re add test Signed-off-by: ktf <[email protected]> * Disable on mac Signed-off-by: ktf <[email protected]> * Fix clippy error Signed-off-by: ktf <[email protected]> Signed-off-by: Duy Do <[email protected]>
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
…ectordotdev#4165) * Re add test Signed-off-by: ktf <[email protected]> * Disable on mac Signed-off-by: ktf <[email protected]> * Fix clippy error Signed-off-by: ktf <[email protected]> Signed-off-by: Brian Menges <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #3780
Test now periodically checks if the file has been removed with max total wait of 20sec.