refactor(config): prepare schema-driven value coercion by pront · Pull Request #26450 · vectordotdev/vector

pront · 2026-09-21T19:20:08Z

Summary

Extract the schema-coercion groundwork from #25905 so it can be reviewed independently of the breaking parse-first loading change.

Introduce ValueCoercer to keep the root schema, definition lookup, and error-path state together, with tests in a separate module.
Cover scalar coercion, references, arrays, unions, generated ConfigBuilder schemas, and numeric boundaries. Reject the rounded 2^63 float boundary instead of silently saturating it to i64::MAX.
Leave runtime loading unchanged: the loader does not invoke the new coercer. Serde remains the authoritative validator.

References

Related: #25905. Follows merged #26441; based directly on master, not stacked.

How did you test this PR?

make fmt and cargo fmt --all -- --check passed.
cargo nextest run -p vector --lib --no-default-features --features sources-demo_logs config::loading: 39 passed, including 12 coercion tests. A repeat run was clean after one passing test was marked leaky on the first run.
Production-library Clippy passed with sources-demo_logs and warnings denied.
make check-clippy FEATURES=sources-demo_logs is blocked by the existing clippy::unused_async finding at src/test_util/http.rs:51; that file is unchanged from master.

Does this PR include user facing changes?

Yes.
No. A maintainer will apply the no-changelog label to this PR.

chatgpt-codex-connector · 2026-09-21T19:20:22Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-22T20:38:14.539625Z	`843df8e`	New commits
🔒 Security Review	✅ Completed 2026-09-22T20:35:23.236444Z	`843df8e`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 696b6b1b32

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 10235e9b28

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fc43d7138d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 034c98fd38

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 843df8e5d2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-22T20:38:11Z

+        if let Some(schema_type) = schema.get("type") {
+            return match schema_type {
+                Value::String(schema_type) => value_matches_type(value, schema_type),
+                Value::Array(schema_types) => schema_types
+                    .iter()


Infer const types before ranking union branches

When an optional externally tagged unit enum has a valid variant spelling "null", its generated Option schema places the null branch before the enum branch, but this function reports no structural match for the enum's const-only schema because it only recognizes explicit type values. Both branches therefore reach the coercive pass, where the null branch converts "null" to JSON null and commits, causing serde to produce None instead of the enum variant. The fresh evidence beyond the earlier Option<SensitiveString> fix is that generate_const_string_schema emits const without type, which this recursive shape check still cannot classify; infer scalar shape from const and enum before ranking branches.

Useful? React with 👍 / 👎.

pront requested a review from a team as a code owner September 21, 2026 19:20

pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Sep 21, 2026

chatgpt-codex-connector Bot reviewed Sep 21, 2026

View reviewed changes

Comment thread src/config/loading/schema_coercion.rs

Comment thread src/config/loading/schema_coercion.rs Outdated

Comment thread src/config/loading/schema_coercion.rs Outdated

Comment thread src/config/loading/schema_coercion.rs

chatgpt-codex-connector Bot reviewed Sep 21, 2026

View reviewed changes

Comment thread src/config/loading/schema_coercion.rs Outdated

Comment thread src/config/loading/schema_coercion.rs Outdated

chatgpt-codex-connector Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread src/config/loading/schema_coercion.rs Outdated

Comment thread src/config/loading/schema_coercion.rs Outdated

Comment thread src/config/loading/schema_coercion.rs Outdated

pront mentioned this pull request Sep 22, 2026

refactor(config): remove component base metadata #26459

Merged

2 tasks

pront added 4 commits September 22, 2026 14:55

refactor(config): prepare schema-driven value coercion

c282c39

fix(config): preserve value shapes during schema coercion

c156cfb

fix(config): respect schema union predicates and field aliases

16f5ca0

fix(config): locate component coercion boundaries structurally

599ec6d

pront force-pushed the pront-prepare-schema-coercion branch from fc43d71 to 599ec6d Compare September 22, 2026 19:04

pront added 2 commits September 22, 2026 15:22

fix(config): preserve union shapes and enum aliases during coercion

671ce69

refactor(config): simplify coercion dispatch and name test cases

034c98f

chatgpt-codex-connector Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread src/config/loading/schema_coercion.rs Outdated

Comment thread src/config/loading/schema_coercion.rs Outdated

fix(config): preserve enum spelling and unsigned float range

843df8e

chatgpt-codex-connector Bot reviewed Sep 22, 2026

View reviewed changes

Navigation Menu

refactor(config): prepare schema-driven value coercion - #26450

refactor(config): prepare schema-driven value coercion#26450
pront wants to merge 7 commits into
masterfrom
pront-prepare-schema-coercion

pront commented Sep 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 21, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Sep 22, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

pront commented Sep 21, 2026

Summary

References

How did you test this PR?

Does this PR include user facing changes?

Uh oh!

chatgpt-codex-connector Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chatgpt-codex-connector Bot commented Sep 21, 2026 •

edited

Loading