Conversation
Sink conversions need a canonical in-memory trace that can hold OTLP and Datadog fields without stuffing them into a LogEvent map. Add `vector_core::event::typed_trace` behind the typed-trace feature and leave `Event::Trace` as the legacy newtype so sources and the topology stay unchanged. The type encodes the data types specified in RFC 25329 plus the invariants later mappings rely on.
bruceg
added
domain: traces
github-actions
Bot
added
the
docs review on hold
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tessneau
left a comment
tessneau
left a comment
There was a problem hiding this comment.
looks good, nothing blocking from my end 🎉
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a88e56cfbe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d98233421
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This branch has not been deployed
2 participants
Summary
Sink conversions need a canonical in-memory trace that can hold OTLP and Datadog fields without stuffing them into a LogEvent map. Add
vector_core::event::typed_tracebehind the typed-trace feature and leaveEvent::Traceas the legacy newtype so sources and the topology stay unchanged.The type encodes the data types specified in RFC 25329 plus the invariants later mappings rely on.
References
Vector configuration
N/A
How did you test this PR?
N/A code adds no active functionality
Does this PR include user facing changes?
no-changeloglabel to this PR.Contributor Guidelines
@vectordotdev/vectorto reach out to us regarding this PR.git merge origin masterandgit push.