-
Notifications
You must be signed in to change notification settings - Fork 2.1k
enhancement(tag_cardinality_limit transform): Add more fine grained controls tag cardinality #25360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ArunPiduguDD
wants to merge
1
commit into
arun.pidugu/tag-cardinality-tracking-scope
Choose a base branch
from
arun.pidugu/add-more-fine-grained-controls-tag-cardinality
base: arun.pidugu/tag-cardinality-tracking-scope
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
26 changes: 26 additions & 0 deletions
26
changelog.d/tag_cardinality_limit_per_tag_and_exclude.enhancement.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| The `tag_cardinality_limit` transform gained two new configuration capabilities: | ||
|
|
||
| - **Per-tag overrides**: each entry in `per_metric_limits` now supports a `per_tag_limits` | ||
| map whose entries can override settings for a specific tag key on that metric. Each | ||
| per-tag field is optional: | ||
| - `value_limit`: caps distinct values for this tag key. Inherits from the enclosing | ||
| per-metric `value_limit` when unset. | ||
| - `mode`: cardinality tracking mode (`exact`, `probabilistic`, or `excluded`). Inherits | ||
| from the enclosing per-metric `mode` when unset. | ||
| - `cache_size_per_key`: bloom filter cache size in bytes. Only meaningful when the | ||
| effective `mode` is `probabilistic`. Inherits from the enclosing per-metric | ||
| `cache_size_per_key` when unset (when the per-metric mode is also probabilistic), | ||
| otherwise falls back to the default. | ||
|
|
||
| `limit_exceeded_action` and `internal_metrics` are not per-tag-overridable; the metric's | ||
| values are used. Per-metric configuration semantics are unchanged from prior versions: | ||
| per-metric entries remain self-contained, with each unset field using its existing serde | ||
| default. | ||
| - **Exclusion**: `mode: excluded` is now available as a third mode option in `per_metric_limits` | ||
| and `per_tag_limits` entries (not at the global level). When set, the metric or tag is opted | ||
| out of cardinality control — all tag values pass through and nothing is tracked. Other | ||
| tracking fields on the entry (`value_limit`) are ignored when `mode: excluded` is selected. | ||
| Per-metric exclusion is blanket: when a metric's `mode` is `excluded`, every tag on that | ||
| metric is excluded and any `per_tag_limits` overrides on it are ignored. | ||
|
|
||
| authors: ArunPiduguDD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.