Skip to content

libvcs 0.33.0 (test performance improved) #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2024
Merged

libvcs 0.33.0 (test performance improved) #453

merged 4 commits into from
Oct 13, 2024

Conversation

tony
Copy link
Member

@tony tony commented Oct 12, 2024

Problem

Git, Subversion, and Mercurial repositories are unnecessarily reinitialized for each test via libvcs' pytest plugin.

Improvement

Note

If run again, these may not work due to changes in fixture naming and behavior between versions, as well as modifications to how they are used in the pull request.

❯ hyperfine \
  --warmup 3 \
  --runs 10 \
  --prepare 'pip uninstall -y libvcs && pip install "libvcs==0.30.1"' \
  --command-name 'libvcs 0.30.1' \
  'py.test' \
  --prepare 'pip uninstall -y libvcs && pip install "libvcs==0.31.0"' \
  --command-name 'libvcs 0.31.0' \
  'py.test' \
  --prepare 'pip uninstall -y libvcs && pip install "libvcs==0.32.1"' \
  --command-name 'libvcs 0.32.1' \
  'py.test'
Benchmark 1: libvcs 0.30.1
  Time (mean ± σ):      4.784 s ±  0.116 s    [User: 4.641 s, System: 0.846 s]
  Range (min … max):    4.599 s …  4.971 s    10 runs

Benchmark 2: libvcs 0.31.0
  Time (mean ± σ):      3.436 s ±  0.115 s    [User: 2.821 s, System: 0.470 s]
  Range (min … max):    3.347 s …  3.678 s    10 runs

Benchmark 3: libvcs 0.32.1
  Time (mean ± σ):      3.173 s ±  0.054 s    [User: 2.726 s, System: 0.388 s]
  Range (min … max):    3.104 s …  3.295 s    10 runs

Summary
  libvcs 0.32.1 ran
    1.08 ± 0.04 times faster than libvcs 0.31.0
    1.51 ± 0.04 times faster than libvcs 0.30.1

Changes

libvcs 0.30.1 -> 0.33.0

See also:

Appendix

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.42%. Comparing base (2bcc550) to head (f2bead6).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
- Coverage   84.45%   84.42%   -0.04%     
==========================================
  Files          16       16              
  Lines         933      931       -2     
  Branches      137      137              
==========================================
- Hits          788      786       -2     
  Misses         92       92              
  Partials       53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony tony force-pushed the libvcs-0.31.0 branch 2 times, most recently from 686a633 to 83bec5a Compare October 13, 2024 12:21
tony added 3 commits October 13, 2024 07:22
Fixed 5 errors:
- conftest.py:
    2 × PT001 (pytest-fixture-incorrect-parentheses-style)
- tests/test_config.py:
    1 × PT001 (pytest-fixture-incorrect-parentheses-style)
- tests/test_config_file.py:
    2 × PT001 (pytest-fixture-incorrect-parentheses-style)
@tony tony merged commit 4567562 into master Oct 13, 2024
9 checks passed
@tony tony deleted the libvcs-0.31.0 branch October 13, 2024 12:32
@tony tony changed the title libvcs 0.31.0 (test performance improved) libvcs 0.33.0 (test performance improved) Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant