Fix address format to conform to EIP-55 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vbuterin#20 Update address format to conform to EIP-55. * **utils.py**: Add `to_checksum_address` function to convert an address to EIP-55 format and `is_checksum_address` function to validate an address against EIP-55 format. * **manager.py**: Import `to_checksum_address` from `utils.py`. Update `genaddr` function to return address in EIP-55 format using `to_checksum_address`. * **blocks.py**: Import `is_checksum_address` from `utils.py`. Update address validation logic in `pay_fee`, `get_nonce`, `get_balance`, `set_balance`, `get_contract`, and `update_contract` methods to use `is_checksum_address`. * **transactions.py**: Import `is_checksum_address` from `utils.py`. Update `parse` method to validate `self.to` and `self.sender` addresses using `is_checksum_address`. * **tests/test_utils.py**: Add tests for `to_checksum_address` and `is_checksum_address` functions. * **tests/test_manager.py**: Update tests for `genaddr` function to check for EIP-55 formatted addresses. * **tests/test_blocks.py**: Update tests for `pay_fee`, `get_nonce`, `get_balance`, `set_balance`, `get_contract`, and `update_contract` methods to check for EIP-55 formatted addresses. * **tests/test_transactions.py**: Update tests for `parse` method to check for EIP-55 formatted addresses. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/vbuterin/pyethereum/issues/20?shareId=XXXX-XXXX-XXXX-XXXX).
Setland34
commented
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
Update address format to conform to EIP-55.
to_checksum_addressfunction to convert an address to EIP-55 format andis_checksum_addressfunction to validate an address against EIP-55 format.to_checksum_addressfromutils.py. Updategenaddrfunction to return address in EIP-55 format usingto_checksum_address.is_checksum_addressfromutils.py. Update address validation logic inpay_fee,get_nonce,get_balance,set_balance,get_contract, andupdate_contractmethods to useis_checksum_address.is_checksum_addressfromutils.py. Updateparsemethod to validateself.toandself.senderaddresses usingis_checksum_address.to_checksum_addressandis_checksum_addressfunctions.genaddrfunction to check for EIP-55 formatted addresses.pay_fee,get_nonce,get_balance,set_balance,get_contract, andupdate_contractmethods to check for EIP-55 formatted addresses.parsemethod to check for EIP-55 formatted addresses.For more details, open the Copilot Workspace session.