Feature/air quality status page by vbuch · Pull Request #337 · vbuch/oboapp

vbuch · 2026-04-03T05:43:35Z

vercel · 2026-04-03T05:43:41Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
oboapp-api	Ready	Preview, Comment	Apr 3, 2026 7:39pm
oborishte-map	Ready	Preview, Comment	Apr 3, 2026 7:39pm

Copilot

Pull request overview

Adds a dedicated /air-quality monitoring page (with map + stats) and a backing API endpoint so the team can inspect sensor.community crawler data and notification/message counts without waiting for notifications to trigger.

Changes:

Added /air-quality UI with Leaflet grid-cell visualization, summary stats, and recent messages from sensor-community.
Added /api/air-quality/status route that reads the latest 24h readings from GCS/local FS, computes per-cell EAQI (NowCast), and returns DB counts.
Centralized EAQI/NowCast math in @oboapp/shared and updated ingest to re-export it; added a MongoDB index for notificationMatches.messageSnapshot.source.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
web/package.json	Adds `@google-cloud/storage` dependency for server-side GCS reads.
web/components/AirQualityMap.tsx	New client component rendering EAQI grid cells on a Leaflet map.
web/app/api/air-quality/status/route.ts	New API route: loads readings (GCS/local), computes per-cell EAQI, returns freshness + DB counts.
web/app/air-quality/page.tsx	New monitoring page UI (stats, map, legend, recent alerts, message detail).
web/app/air-quality/layout.tsx	Imports Leaflet CSS at route-segment layout scope.
web/.env.example	Documents `GCS_READINGS_BUCKET` and `LOCAL_READINGS_PATH` for the monitoring page.
shared/src/index.ts	Exposes the shared EAQI module via package index export.
shared/src/air-quality/aqi.ts	New shared EAQI/NowCast implementation (PM2.5/PM10 bands + labels/categories).
ingest/lib/air-quality/constants.ts	Re-exports `NOWCAST_MIN_WEIGHT` from `@oboapp/shared`.
ingest/lib/air-quality/aqi.ts	Replaces local EAQI implementation with re-exports from `@oboapp/shared`.
db/src/indexes.ts	Adds MongoDB index for `notificationMatches.messageSnapshot.source` used by the new status API.
pnpm-lock.yaml	Lockfile updates for added dependency and resulting resolution changes.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

web/components/AirQualityMap.tsx

web/app/air-quality/page.tsx

web/app/api/air-quality/status/route.ts

shared/src/air-quality/aqi.ts

web/.env.example

vbuch · 2026-04-03T06:05:35Z

@copilot address comments in this PR

Copilot · 2026-04-03T06:13:45Z

@copilot address comments in this PR

All review comments addressed in c3caa38:

Variable shadowing — renamed const colors → const cellStyle in AirQualityMap.tsx
Error states — added isError from both useQuery calls in page.tsx; each failing section now renders an explicit error message instead of silently showing empty/dash states
assignToCell performance — switched from grid.find() to a for...of loop
Storage singleton — cached at module scope so repeated requests reuse the same client
Number.isFinite — replaced !Number.isNaN in nowCastWeightedAverage to also filter out Infinity
Tests — added shared/src/air-quality/aqi.test.ts with 27 tests covering bands, NowCast weighting, label/category boundaries, and Infinity/NaN filtering
Docs — updated docs/features/air-quality-monitoring.md with a Monitoring Page section and updated the configuration table

Copilot

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

web/app/air-quality/page.tsx

web/components/AirQualityMap.tsx

docs/features/air-quality-monitoring.md

Copilot

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 5 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

web/app/api/air-quality/status/route.ts

docs/features/air-quality-monitoring.md

…ndling, route tests, NEXT_PUBLIC_LOCALITY docs - Replace Math.min/max spread over validTimestamps with a single loop to avoid hitting the JS argument limit on large 24h datasets - Treat calculateNowCastAqi returning 0 as "no data" (aqi/aqiLabel/aqiCategory → null); sort null-aqi cells last; derive maxAqi via .find() instead of cells[0] - Update AirQualityCell/AqiCell interfaces to allow null aqi/aqiLabel/aqiCategory; fix AirQualityMap tooltip and CATEGORY_COLORS lookup for null aqiCategory - Add /api/air-quality/status route tests (10 tests: locality validation, no-data path, with-data shape, null-aqi propagation, staleness, db stats) - Document NEXT_PUBLIC_LOCALITY in the air-quality-monitoring config table Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

web/app/api/air-quality/status/route.ts

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

- Add /air-quality page with map, AQI overview, and notification stats - Add /api/air-quality/status route serving current AQI, GCS data window, and notification counts - Move AQI helpers from ingest into shared/src/air-quality/aqi.ts and re-export from ingest - Add AirQualityMap component using Mapbox - Add DB index for air quality station queries - Update web/package.json and pnpm-lock.yaml for new dependencies - Document required env vars in web/.env.example

Agent-Logs-Url: https://github.com/vbuch/oboapp/sessions/13906beb-570d-439f-a8f3-b1298dbd0f98

Agent-Logs-Url: https://github.com/vbuch/oboapp/sessions/e7cf278e-1370-4292-a14e-9354592c1e0e Co-authored-by: vbuch <5102057+vbuch@users.noreply.github.com>

Agent-Logs-Url: https://github.com/vbuch/oboapp/sessions/71c896d6-4264-402d-8247-53da19f3493e Co-authored-by: vbuch <5102057+vbuch@users.noreply.github.com>

…ndling, route tests, NEXT_PUBLIC_LOCALITY docs - Replace Math.min/max spread over validTimestamps with a single loop to avoid hitting the JS argument limit on large 24h datasets - Treat calculateNowCastAqi returning 0 as "no data" (aqi/aqiLabel/aqiCategory → null); sort null-aqi cells last; derive maxAqi via .find() instead of cells[0] - Update AirQualityCell/AqiCell interfaces to allow null aqi/aqiLabel/aqiCategory; fix AirQualityMap tooltip and CATEGORY_COLORS lookup for null aqiCategory - Add /api/air-quality/status route tests (10 tests: locality validation, no-data path, with-data shape, null-aqi propagation, staleness, db stats) - Document NEXT_PUBLIC_LOCALITY in the air-quality-monitoring config table Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

GCS_READINGS_BUCKET is set in CI, causing the route to attempt a real GCS connection instead of falling back to the local filesystem. Mock the Storage class (using a class literal so new Storage() works) and supply test data via both paths so tests pass regardless of whether GCS_READINGS_BUCKET is set. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

The previous test placed both readings at the same lat/lng, so they landed in one cell — the second mockReturnValueOnce(0) was never consumed and the sort assertion was skipped behind a conditional. Now uses (42.61, 23.21) → r0c0 and (42.75, 23.45) → r4c5 so two cells are created, calculateNowCastAqi is called once per cell, and the ordering assertion runs unconditionally. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…T to GCS_GENERIC_BUCKET Agent-Logs-Url: https://github.com/vbuch/oboapp/sessions/68cc96d3-9bdc-492e-9b94-74f230f0b5ac Co-authored-by: vbuch <5102057+vbuch@users.noreply.github.com>

Agent-Logs-Url: https://github.com/vbuch/oboapp/sessions/60ddc3a1-a428-48b7-9064-fa717bc175f5 Co-authored-by: vbuch <5102057+vbuch@users.noreply.github.com>

….example comment Agent-Logs-Url: https://github.com/vbuch/oboapp/sessions/c37c3ba0-9626-46d8-8e3e-80ad545210a3

Agent-Logs-Url: https://github.com/vbuch/oboapp/sessions/6dd8dfbc-5a19-4608-bde0-503718f702ab

Copilot AI review requested due to automatic review settings April 3, 2026 05:43

Copilot started reviewing on behalf of vbuch April 3, 2026 05:44 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

vbuch commented Apr 3, 2026

View reviewed changes

web/.env.example Show resolved Hide resolved

Copilot started work on behalf of vbuch April 3, 2026 06:05 View session

vercel bot deployed to Preview – oboapp-api April 3, 2026 06:12 View deployment

vercel bot deployed to Preview – oborishte-map April 3, 2026 06:14 View deployment

Copilot finished work on behalf of vbuch April 3, 2026 06:14

vbuch requested a review from Copilot April 3, 2026 06:20

Copilot started reviewing on behalf of vbuch April 3, 2026 06:20 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

web/app/air-quality/page.tsx Outdated Show resolved Hide resolved

web/components/AirQualityMap.tsx Outdated Show resolved Hide resolved

docs/features/air-quality-monitoring.md Outdated Show resolved Hide resolved

Copilot started work on behalf of vbuch April 3, 2026 06:34 View session

vercel bot deployed to Preview – oboapp-api April 3, 2026 06:36 View deployment

Copilot finished work on behalf of vbuch April 3, 2026 06:36

vercel bot deployed to Preview – oborishte-map April 3, 2026 06:37 View deployment

vbuch requested a review from Copilot April 3, 2026 06:42

Copilot started reviewing on behalf of vbuch April 3, 2026 06:42 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

vercel bot deployed to Preview – oboapp-api April 3, 2026 07:45 View deployment

vercel bot deployed to Preview – oborishte-map April 3, 2026 07:46 View deployment

vercel bot temporarily deployed to Preview – oboapp-api April 3, 2026 07:54 Inactive

vercel bot deployed to Preview – oborishte-map April 3, 2026 07:55 View deployment

vercel bot temporarily deployed to Preview – oboapp-api April 3, 2026 08:06 Inactive

vercel bot deployed to Preview – oborishte-map April 3, 2026 08:07 View deployment

vbuch requested a review from Copilot April 3, 2026 08:07

Copilot started reviewing on behalf of vbuch April 3, 2026 08:08 View session

vercel bot deployed to Preview – oborishte-map April 3, 2026 14:25 View deployment

vbuch requested a review from Copilot April 3, 2026 15:05

Copilot started reviewing on behalf of vbuch April 3, 2026 15:05 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

web/app/api/air-quality/status/route.ts Show resolved Hide resolved

Copilot started work on behalf of vbuch April 3, 2026 15:16 View session

vercel bot temporarily deployed to Preview – oboapp-api April 3, 2026 15:19 Inactive

vercel bot deployed to Preview – oborishte-map April 3, 2026 15:20 View deployment

Copilot finished work on behalf of vbuch April 3, 2026 15:21

vbuch requested a review from Copilot April 3, 2026 15:28

Copilot started reviewing on behalf of vbuch April 3, 2026 15:28 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

vbuch and others added 13 commits April 3, 2026 22:37

fix: address air quality page review feedback

bcf855d

Agent-Logs-Url: https://github.com/vbuch/oboapp/sessions/13906beb-570d-439f-a8f3-b1298dbd0f98

fix: address all PR review comments for air quality page

38eb1a5

Agent-Logs-Url: https://github.com/vbuch/oboapp/sessions/e7cf278e-1370-4292-a14e-9354592c1e0e Co-authored-by: vbuch <5102057+vbuch@users.noreply.github.com>

fix: address second round of air quality page review comments

b9cfe73

Agent-Logs-Url: https://github.com/vbuch/oboapp/sessions/71c896d6-4264-402d-8247-53da19f3493e Co-authored-by: vbuch <5102057+vbuch@users.noreply.github.com>

docs: note that /air-quality page is only reachable by direct URL

8119264

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: replace ЕАКИ with EAQI throughout air quality page

b4f8121

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: exclusive north/east cell boundary and rename GCS_READINGS_BUCKE…

f99922f

…T to GCS_GENERIC_BUCKET Agent-Logs-Url: https://github.com/vbuch/oboapp/sessions/68cc96d3-9bdc-492e-9b94-74f230f0b5ac Co-authored-by: vbuch <5102057+vbuch@users.noreply.github.com>

perf: parse r.timestamp once per reading in a single unified loop

a544909

Agent-Logs-Url: https://github.com/vbuch/oboapp/sessions/60ddc3a1-a428-48b7-9064-fa717bc175f5 Co-authored-by: vbuch <5102057+vbuch@users.noreply.github.com>

fix: add nodejs runtime export, hermetic test env stubs, and fix .env…

1251e26

….example comment Agent-Logs-Url: https://github.com/vbuch/oboapp/sessions/c37c3ba0-9626-46d8-8e3e-80ad545210a3

fix: return 503 in production when GCS_GENERIC_BUCKET is not configured

0c129a3

Agent-Logs-Url: https://github.com/vbuch/oboapp/sessions/6dd8dfbc-5a19-4608-bde0-503718f702ab

vbuch force-pushed the feature/air-quality-status-page branch from 80fb993 to 0c129a3 Compare April 3, 2026 19:37

vercel bot deployed to Preview – oboapp-api April 3, 2026 19:38 View deployment

vercel bot deployed to Preview – oborishte-map April 3, 2026 19:39 View deployment

vbuch linked an issue Apr 3, 2026 that may be closed by this pull request

Create a page for previewing the data available from the sensor.community crawler #315

Closed

vbuch merged commit 2fbdc63 into main Apr 3, 2026
7 checks passed

vbuch deleted the feature/air-quality-status-page branch April 3, 2026 19:40

Conversation

vbuch commented Apr 3, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vbuch commented Apr 3, 2026

Uh oh!

Copilot AI commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vbuch commented Apr 3, 2026 •

edited by Copilot AI

Loading

vercel bot commented Apr 3, 2026 •

edited

Loading