-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the benchmark CI #222
Conversation
Benchmark Report✅ Pull request has no significant performance differences ✅ Click to expand comparison resultBenchmark check running at 2025-01-10 13:56:04 UTCThe baseline mmbm-benchmark-ci is EQUAL to the defined thresholds. Click to expand benchmark resultBaseline mmbm-benchmark-ci
SigningES256
EdDSA
RSA
TokenLifecycleES256 Generated
ES256 PEM
EdDSA Coordinates
EdDSA Generated
RSA PEM
VerifyingES256
EdDSA
RS256
|
af7f7e0
to
99bcb7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A zillion little nits mostly about how to use Bash.
ee82025
to
c6209b3
Compare
3787c39
to
9ce35f3
Compare
7be528b
to
546a8b1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
=======================================
Coverage 83.79% 83.79%
=======================================
Files 56 56
Lines 1493 1493
=======================================
Hits 1251 1251
Misses 242 242 |
3566ef4
to
4846845
Compare
# Run the job only if it's a manual workflow dispatch, or if this event is a pull-request approval event, or if someone has rerun the job. | ||
if: github.event_name == 'workflow_dispatch' || github.event.review.state == 'approved' || github.run_attempt > 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paths: | ||
- 'Sources/*.swift' | ||
- .github/workflows/benchmark.yml | ||
- Sources/*.swift | ||
- Benchmarks/*.swift | ||
- .github/workflows/benchmark.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added - Benchmarks/*.swift
too
No description provided.