Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jwt.de.md german translation for #977 #997

Merged
merged 29 commits into from
Aug 11, 2024
Merged

jwt.de.md german translation for #977 #997

merged 29 commits into from
Aug 11, 2024

Conversation

plse73
Copy link
Contributor

@plse73 plse73 commented Aug 3, 2024

No description provided.

@plse73 plse73 requested a review from a team as a code owner August 3, 2024 11:09
@plse73
Copy link
Contributor Author

plse73 commented Aug 3, 2024

This is my first contribution to the Git community and the processing of open issues. Since I am German and my native language level is German, I hoped to be able to offer added value here. Hopefully I could help and of course I'm looking forward to your feedback.
Best regards

@plse73 plse73 mentioned this pull request Aug 3, 2024
Closed
9 tasks
@plse73
Copy link
Contributor Author

plse73 commented Aug 3, 2024

Here I have made the translation into German. Unfortunately I could not find the desired label(translation-update) to add it to the request. Clarification would be great here so that I can take it into account in the future.

@0xTim 0xTim added the translation-update This PR contains translations for the docs label Aug 3, 2024
@0xTim
Copy link
Member

0xTim commented Aug 3, 2024

Thanks @plse73 ! I've added the label, it might be you need to scroll to see it or not have permissions yet. I'll leave this for a bit to see if anyone wants to proof read!

ptoffy
ptoffy requested changes Aug 4, 2024
View reviewed changes
Copy link
Member

@ptoffy ptoffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I have a few nits about using a consistent Anrede in the whole file. Also let's make sure the spacing around titles etc is consistent (e.g leave a space below (sub)titles). Looks good otherwise

docs/security/jwt.de.md Outdated Show resolved Hide resolved
docs/security/jwt.de.md Outdated Show resolved Hide resolved
docs/security/jwt.de.md Outdated Show resolved Hide resolved
docs/security/jwt.de.md Outdated Show resolved Hide resolved
docs/security/jwt.de.md Outdated Show resolved Hide resolved
docs/security/jwt.de.md Outdated
app.jwt.google.gSuiteDomainName = "..."
```

Verwenden Sie dann die Hilfe `req.jwt.google`, um ein Google JWT zu holen und zu überprüfen.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

docs/security/jwt.de.md Outdated

### Microsoft

Konfigurieren Sie zunächst die Kennung Ihrer Microsoft-Anwendung.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

docs/security/jwt.de.md Outdated
Konfigurieren Sie zunächst die Kennung Ihrer Microsoft-Anwendung.

```swift
// Konfigurieren Sie die Kennung der Microsoft-App.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

docs/security/jwt.de.md Outdated
app.jwt.microsoft.applicationIdentifier = "..."
```

Verwenden Sie dann die Hilfsfunktion `req.jwt.microsoft`, um ein Microsoft JWT abzurufen und zu überprüfen.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

docs/security/jwt.de.md Outdated Show resolved Hide resolved
plse73 and others added 22 commits August 5, 2024 09:59
@plse73 @ptoffy
Apply suggestions from code review
f7c3ff8 
tag changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
0e3db2a 
small tag changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
58d7cee 
singular

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
5b25a2a 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
953b134 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
8f62165 
tag changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
ca11e06 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
21cbf25 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
081f3b8 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
874aeb0 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
45545dc 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
66480f8 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
50cfc4b 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
649843f 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
88998a0 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
583effb 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
9de35d8 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
948df9e 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
e42add2 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
dc2cb1e 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
58723bc 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
a886c21 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
plse73 and others added 6 commits August 5, 2024 10:12
@plse73 @ptoffy
Apply suggestions from code review
ef12ad9 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
b7036d4 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73 @ptoffy
Apply suggestions from code review
96fd427 
salutation changes

Co-authored-by: Paul Toffoloni <[email protected]>
@plse73
salutation changes
16ec1a0
@plse73
salutation changes
d36d0be
@plse73
salutation changes
87ba85a
plse73
plse73 commented Aug 5, 2024
View reviewed changes
Copy link
Contributor Author

@plse73 plse73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your detailed feedback and comments regarding my mistakes. I hope that I have made the correction in a way that it is now visible. I had a note regarding one of the corrections.

Best regards,

Philip

docs/security/jwt.de.md Outdated
Sie können dieses JSON Web Key Set (JWKS) zu Ihren `JWTSigners` hinzufügen.
Sie können dann JWTs von Apple an die Methode `verify` übergeben. Der Schlüsselbezeichner (`kid`) im JWT-Header wird verwendet, um automatisch den richtigen Schlüssel für die Verifizierung auszuwählen.

JWT-Herausgeber können ihre JWKS rotieren, was bedeutet, dass Sie gelegentlich einen neuen Download durchführen müssen. Siehe Vapor's unterstützte JWT [Vendors](#vendors) Liste unten für APIs, die dies automatisch tun.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JWT-Herausgeber können ihre JWKS rotieren, was bedeutet, dass du gelegentlich einen neuen Download durchführen musst. Siehe Vapor's unterstützte JWT Vendors Liste unten für APIs, die dies automatisch tun.

Thanks for your solution, but in this context it should read "musst"

@ptoffy
Copy link
Member

ptoffy commented Aug 8, 2024

Yep that's a typo on me!

@ptoffy ptoffy self-requested a review August 8, 2024 06:47
@plse73
Copy link
Contributor Author

plse73 commented Aug 10, 2024

@ptoffy do I have to do anything else, because the merging is blocked for me. I am not an authorized user for this branch. How do I proceed?

@0xTim 0xTim merged commit c2f2b32 into vapor:main Aug 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptoffy ptoffy ptoffy approved these changes

Assignees
No one assigned
Labels
translation-update This PR contains translations for the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plse73 @0xTim @ptoffy