make ExecuteStringStd to be compatible to strings.Replacer on nested tags #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @valyala!
In #23 we added ExecuteStringStd which works as a drop-in replacement to strings.Replacer.
It worked great, but we found a missmatch on nested start/end tags.
Here is an example:
After replacing id with strings.Replacer:
After replacing id with fasttemplate.ExecuteStringStd:
The reason is because fasttemplate takes the first start tag it finds, but strings.Replacer takes the closest to the end tag.
So i made a PR to change the logic only in the
ExecuteStringStd
and other*Std
funcs to make them compatible with strings.Replacer.Please review when you have the time