Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated test script based on PR reviews #25

Merged
merged 1 commit into from
Jan 21, 2025
Merged

updated test script based on PR reviews #25

merged 1 commit into from
Jan 21, 2025

Conversation

Mohsinsiddi
Copy link
Collaborator

PR Description

Enhanced test scripts and workflow configurations with the following improvements:

  1. Removed redundant comment in GitHub workflow configuration for better code clarity
  2. Enhanced logging message for mech service health check bypass to be more descriptive
  3. Streamlined prompt handling in test configurations by:
    • Improving basic prompt responses organization
    • Consolidating common prompt patterns
    • Removing redundant delay timers in test execution

The changes focus on improving code maintainability and test reliability while reducing redundancy in the configuration.

Mohsinsiddi
Mohsinsiddi commented Jan 21, 2025
View reviewed changes
Copy link
Collaborator Author

@Mohsinsiddi Mohsinsiddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good to me

@Mohsinsiddi Mohsinsiddi merged commit 6a214a8 into fix/ENS-error Jan 21, 2025
2 checks passed
@OjusWiZard OjusWiZard deleted the feat/updated_on_reveiws branch January 21, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Mohsinsiddi