Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated test script for better handling of please enter based prompts… #22

Merged
merged 4 commits into from
Jan 20, 2025
Merged

updated test script for better handling of please enter based prompts… #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1971b54
updated test script for better handling of please enter based prompts…
Mohsinsiddi Jan 17, 2025
6f7f1bc
updated ci file to trigger on every PR
Mohsinsiddi Jan 17, 2025
beb6a4e
updated operate hash to fix latest issue
Mohsinsiddi Jan 20, 2025
b9d16d8
updated test script based on PR comments
Mohsinsiddi Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions .github/workflows/python-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: Quickstart Tests
on:
pull_request:
branches:
- main
pull_request: # Removed branches restriction to run on all PRs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the comment, I guess you wanted me to read this comment? If that's the case then just comment it like this one in the PR. Because the comment in the code, doesn't make sense to a 3rd person.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

workflow_dispatch: # Add manual trigger option

jobs:
Expand All @@ -17,10 +15,10 @@ jobs:
DOCKER_LOGS_DIR: ${GITHUB_WORKSPACE}/logs

steps:
- uses: actions/checkout@v4 # Updated from v3
- uses: actions/checkout@v4

- name: Set up Python 3.10
uses: actions/setup-python@v5 # Updated from v4
uses: actions/setup-python@v5
with:
python-version: '3.10'

Expand Down Expand Up @@ -120,11 +118,11 @@ jobs:

- name: Upload test logs
if: always()
uses: actions/upload-artifact@v4 # Updated from v3
uses: actions/upload-artifact@v4
with:
name: test-logs
path: |
logs/
/logs/
.env
retention-days: 30 # Added retention period
retention-days: 30
Loading
Loading