Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP-DO-NOT-MERGE) feat: Support-for: 3.12/3.13 #2316

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

8ball030
Copy link
Contributor

@8ball030 8ball030 commented Mar 14, 2025

Proposed changes

Basically i am little blocked on support for 3.13.

This seems to be caused by a couple of issues.

A) abci relies on grpcio 1.53.0 This fails with a compilation error in python 3.12 when trying to build the wheel.
By bumping to 1.71.0 we should solve this.

B) tomte/flake8
Unfortunately, flake8 is needed for tox etc which conflicts with the grpcio when trying to bump as in this pr
valory-xyz/tomte#29

C) Open-aea-cosmpy which is causing the failing ci.
Upstream however has the solution to get 3.12 working.

Could we please create this pr as I am unable to do so;
image

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • [ x] I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@8ball030 8ball030 changed the title feat: Support-for: 3.12/3.13 (WIP-DO-NOT-MERGE) feat: Support-for: 3.12/3.13 Mar 14, 2025
@8ball030
Copy link
Contributor Author

Interesting grpcio appears to have been this guys issue as well;

#2223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant