Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor (Fetch): Allow fetching from TokenID #2273

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

OjusWiZard
Copy link
Member

Proposed changes

Start deprecating autonomy deploy from-token and move towards the flow:

autonomy fetch <token_id>
autonomy build-image 
autonomy deploy build <retrieved folder>
autonomy deploy run

Fixes

Closes #1948

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Copy link
Collaborator

@Adamantios Adamantios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would also like to suggest whenever we catch a FailedToRetrieveComponentMetadata exception, to additionally suggest the user to make sure that they have set all the necessary environment variables and point them to the nice documentation you have added here.

For example, if the user has not set the RPC, instead of:

Error: Error connecting to the RPC

We could show something like:

Error: Error connecting to the RPC. Please make sure that you have set all the required environment variables correctly. You can read more about the configurations in this/doc/section.

@Adamantios Adamantios merged commit dc4a095 into valory-xyz:main Oct 22, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design issues related to autonomy deploy from-token
3 participants