Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import check #2146

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Add import check #2146

merged 2 commits into from
Jan 23, 2024

Conversation

angrybayblade
Copy link
Contributor

@angrybayblade angrybayblade commented Jan 23, 2024

Proposed changes

This PR add a clean installation check to avoid missing dependency issues from the framework

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

@angrybayblade
Copy link
Contributor Author

Made a temporary commit to check if it works or not and the check works - https://github.com/valory-xyz/open-autonomy/actions/runs/7622558730/job/20760831758?pr=2146

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68b4313) 94.52% compared to head (0d27462) 94.53%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2146   +/-   ##
=======================================
  Coverage   94.52%   94.53%           
=======================================
  Files         259      259           
  Lines       15914    15914           
=======================================
+ Hits        15043    15044    +1     
+ Misses        871      870    -1     
Flag Coverage Δ
unittests 94.53% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Adamantios
Copy link
Collaborator

Made a temporary commit to check if it works or not and the check works - https://github.com/valory-xyz/open-autonomy/actions/runs/7622558730/job/20760831758?pr=2146

The check failed.

@angrybayblade
Copy link
Contributor Author

angrybayblade commented Jan 23, 2024

Made a temporary commit to check if it works or not and the check works - https://github.com/valory-xyz/open-autonomy/actions/runs/7622558730/job/20760831758?pr=2146

The check failed.

It was supposed to

@Adamantios
Copy link
Collaborator

Made a temporary commit to check if it works or not and the check works - https://github.com/valory-xyz/open-autonomy/actions/runs/7622558730/job/20760831758?pr=2146

The check failed.

It was supposed to

Ok, so you tested that it fails using f092e0f.

@angrybayblade angrybayblade merged commit 1dac3a6 into main Jan 23, 2024
27 of 36 checks passed
@DavidMinarsch DavidMinarsch deleted the fix/add-import-check branch March 13, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants