fix: Switch staking contract not working properly #756
+340
−257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teButton error handling
…s for better type safety
mohandast52
commented
Feb 11, 2025
| @@ -78,8 +80,12 @@ export const useStakingProgram = () => { | |||
| selectedStakingProgramMeta, | |||
|
|
|||
| // all staking programs | |||
| allStakingProgramIds: Object.keys(allStakingProgramNameAddressPair), | |||
| allStakingProgramAddress: Object.values(allStakingProgramNameAddressPair), | |||
| allStakingProgramIds: Object.keys( | |||
There was a problem hiding this comment.
I’ll update the types without using “as” whenever I get the time 😞
(Hate using "as" 🥲)
Comment on lines
188
to
192
| setIsMigrating(false); | ||
| setActiveStakingProgramId(stakingProgramIdToMigrateTo); | ||
| overrideSelectedServiceStatus(MiddlewareDeploymentStatus.DEPLOYING); | ||
| goto(Pages.Main); | ||
|
|
There was a problem hiding this comment.
let me know your thoughts on this or 👍 if fine to keep this.
frontend/components/MainPage/header/AgentButton/AgentNotRunningButton.tsx
Outdated
Show resolved
Hide resolved
frontend/components/ManageStakingPage/StakingContractSection/MigrateButton.tsx
Outdated
Show resolved
Hide resolved
Tanya-atatakai
approved these changes
Feb 11, 2025
truemiller
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Iason mentioned that it’s not switching as expected, but based on the pattern, it seems to be switching to the default staking program. Interestingly, this issue appears to occur only on Windows. The root cause is still unknown, but I’ve made some updates:
Please review and let me know your thoughts on potential root causes.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply