Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Move middleware to olas-operate-middleware #737

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Refactor: Move middleware to olas-operate-middleware #737

merged 2 commits into from
Feb 5, 2025

Conversation

OjusWiZard
Copy link
Member

Proposed changes

  • Move the middleware python package to a separate repo: olas-operate-middleware
  • Only keeping pearl.py and tendermint.py for making binaries
  • Other adjustments in CI, build scripts, packaging scripts, etc.

Note: I will start cleaning up the Pearl related code in the other repo after getting an initial feedback in this PR

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor

Base automatically changed from fix/meme-staging to staging February 5, 2025 09:51
mohandast52
mohandast52 approved these changes Feb 5, 2025
View reviewed changes
.gitleaksignore
af77e930289cbc87987567bff0efc25936484df2:backend/controller.py:generic-api-key:354
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we delete gitleaks? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it checks the FE code also, then we can keep it

@OjusWiZard OjusWiZard merged commit 055a805 into staging Feb 5, 2025
3 checks passed
@OjusWiZard OjusWiZard deleted the refactor/middleware-separation branch February 5, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohandast52 mohandast52 mohandast52 approved these changes

@Tanya-atatakai Tanya-atatakai Tanya-atatakai approved these changes

@solarw solarw Awaiting requested review from solarw

@truemiller truemiller Awaiting requested review from truemiller

@jmoreira-valory jmoreira-valory Awaiting requested review from jmoreira-valory

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OjusWiZard @mohandast52 @Tanya-atatakai