Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup wallet address fixes #593

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Backup wallet address fixes #593

merged 7 commits into from
Dec 16, 2024

Conversation

truemiller
Copy link
Collaborator

@truemiller truemiller commented Dec 16, 2024 •
edited
Loading

Proposed changes

  • Fallback to backup safe during on-boarding, if backup signer is not set (via first load)
  • Require backup address consistency if deploying agent, and safe does not exist yet

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@truemiller truemiller changed the title Ensure backup wallet passed during safe creation post-onboarding Backup wallet address fixes Dec 16, 2024
@truemiller truemiller merged commit a1895ff into fix/meme-staging Dec 16, 2024
4 of 5 checks passed
@truemiller truemiller deleted the fix/post-onboarding-backup-wallet branch December 16, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tanya-atatakai Tanya-atatakai Tanya-atatakai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@truemiller @Tanya-atatakai