Fix requests count and scripts #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kupermind
commented
Jan 24, 2025
kupermind
commented
- Fix requests count;
- Update a script to track NVM subscription credits.
kupermind
requested review from
DavidMinarsch,
77ph,
Sfgangloff and
mariapiamo
kupermind
commented
Jan 24, 2025
| @@ -51,7 +51,7 @@ struct RequestInfo { | |||
| /// @author Andrey Lebedev - <[email protected]> | |||
| /// @author Silvere Gangloff - <[email protected]> | |||
| contract MechMarketplace is IErrorsMarketplace { | |||
| event CreateMech(address indexed mech, uint256 indexed serviceId); | |||
| event CreateMech(address indexed mech, uint256 indexed serviceId, address indexed mechFactory); | |||
There was a problem hiding this comment.
Makes sense to add a factory address into this event
kupermind
commented
Jan 24, 2025
Comment on lines
+762
to
+764
| mapDeliveryCounts[requester] += numRequests; | ||
| // Increase the amount of mech delivery counts | ||
| mapMechDeliveryCounts[msg.sender]++; | ||
| mapMechDeliveryCounts[msg.sender] += numRequests; |
There was a problem hiding this comment.
Fix as we are dealing with batches :)
Sfgangloff
approved these changes
Jan 24, 2025
mariapiamo
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.