Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deployment scripts #75

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

kupermind
Copy link
Collaborator

  • Deployment scripts.

Comment on lines -56 to -65
if (_subscriptionNFT == address(0)) {
revert ZeroAddress();
}

if (_subscriptionTokenId == 0) {
revert ZeroValue();
}

subscriptionNFT = _subscriptionNFT;
subscriptionTokenId = _subscriptionTokenId;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subscription is set separately as it needs to be tied to this contract address

Comment on lines +54 to +55
// Temporary owner address
address public owner;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary ownership is dropped when the subscription is set

/// @dev Process mech payment.
/// @param mech Mech address.
/// @return mechPayment Mech payment.
function _processPayment(address mech) internal virtual override returns (uint256 mechPayment, uint256) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as the understanding goes, all the fees are already accounted for when the subscription is paid for and mech gets its cleared cut.

Base automatically changed from off_chain to nvm_adjustment January 14, 2025 21:29
Base automatically changed from nvm_adjustment to address_audit January 14, 2025 21:33
@DavidMinarsch DavidMinarsch merged commit 7ce80cf into address_audit Jan 14, 2025
0 of 2 checks passed
@DavidMinarsch DavidMinarsch deleted the test_subscription branch January 14, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants