Embetter tests #322
Merged
Embetter tests #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #322 +/- ##
==========================================
+ Coverage 86.21% 86.32% +0.11%
==========================================
Files 129 129
Lines 4650 4659 +9
Branches 601 602 +1
==========================================
+ Hits 4009 4022 +13
+ Misses 447 445 -2
+ Partials 194 192 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
akx
requested review from
a team,
Copilot,
ruksi and
dangquangdon
and removed request for
a team
There was a problem hiding this comment.
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
valohai_cli/commands/yaml/step.py:94
- Ensure that the removal of 'project.refresh_details()' is intentional, as omitting this call might leave the project details stale after updating the YAML configuration. If the refresh is still required, consider reintroducing this call or providing an alternative mechanism to update project details.
project.refresh_details()
teroyks
approved these changes
Apr 4, 2025
| project_id: str = DEFAULT_PROJECT_ID, | ||
| *, | ||
| commit_id: str = DEFAULT_COMMIT_ID, | ||
| deployment_id: str = "666", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bit of test cleanup.