Skip to content

Conversation

@vitahlin
Copy link
Contributor

@vitahlin vitahlin commented Dec 9, 2025

GitHub has deprecated older macOS runners, and macos-13 is no longer supported.

  1. The latest version of cross-platform-actions/action does allow running on ubuntu-latest (Linux runner) and does not strictly require macOS.
  2. Previously, cross-platform-actions/[email protected] used runs-on: macos-13. I checked the latest version of cross-platform-actions, and the official examples now use runs-on: ubuntu. I think we can switch from macOS to Ubuntu.

The daily action result of this PR:https://github.com/vitahlin/valkey/actions/runs/20050360909

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.44%. Comparing base (48e0cbb) to head (83e2034).
⚠️ Report is 2 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2920      +/-   ##
============================================
- Coverage     72.47%   72.44%   -0.04%     
============================================
  Files           129      129              
  Lines         70537    70538       +1     
============================================
- Hits          51121    51098      -23     
- Misses        19416    19440      +24     

see 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ref: ${{ env.GITHUB_HEAD_REF }}
- name: test
uses: cross-platform-actions/action@5800fa0060a22edf69992a779adac3d2bb3a6f8a # v0.22.0
uses: cross-platform-actions/action@v0.30.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we pin the SHA instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, use SHA of version 0.30.0 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants