Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup remove unnecessary cast since slot is int #1865

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

hwware
Copy link
Member

@hwware hwware commented Mar 19, 2025

It looks like make no sense here, just remove it.

Signed-off-by: hwware <[email protected]>
@hwware hwware force-pushed the update-getSlotOrReply branch from d581512 to a243bcf Compare March 19, 2025 20:32
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.03%. Comparing base (aa88453) to head (a243bcf).
Report is 1 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1865      +/-   ##
============================================
- Coverage     71.09%   71.03%   -0.07%     
============================================
  Files           123      123              
  Lines         65671    65671              
============================================
- Hits          46692    46649      -43     
- Misses        18979    19022      +43     
Files with missing lines Coverage Δ
src/cluster_legacy.c 85.88% <100.00%> (-0.21%) ⬇️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@enjoy-binbin enjoy-binbin changed the title Remove integer cast Minor cleanup remove unnecessary cast since slot is int Mar 20, 2025
@enjoy-binbin enjoy-binbin merged commit d9ae086 into valkey-io:unstable Mar 20, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants