Valkey release 8.1.0-rc2

[ranshid]

No description provided.

[zuiderkwast]

Looks great.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.02%. Comparing base (63a6516) to head (3dbe286).
Report is 1 commits behind head on 8.1.

Additional details and impacted files

@@            Coverage Diff             @@
##              8.1    #1862      +/-   ##
==========================================
- Coverage   71.06%   71.02%   -0.04%     
==========================================
  Files         123      123              
  Lines       65671    65671              
==========================================
- Hits        46667    46646      -21     
- Misses      19004    19025      +21     

see 10 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[hwware]

I suggest to add the following pr:

#1721 Fix temp file leak druing replication error handling
#1785 Remove unicode optimization in Lua cjson library
#1782 valkey-cli: ensure output ends with a newline if missing when printing reply
#1760 cmd's out bytes need count deferred reply
#1799 Fix hashTypeEntryDefrag returning bad pointer

Thanks @ranshid It is a hard work.

[PingXie]

Thanks @ranshid!

[ranshid]

I suggest to add the following pr:

#1721 Fix temp file leak druing replication error handling
#1785 Remove unicode optimization in Lua cjson library
#1782 valkey-cli: ensure output ends with a newline if missing when printing reply
#1760 cmd's out bytes need count deferred reply
#1799 Fix hashTypeEntryDefrag returning bad pointer

Thanks @ranshid It is a hard work.

#1721 Fix temp file leak druing replication error handling - @enjoy-binbin - should this have also been backported?

#1799 Fix hashTypeEntryDefrag returning bad pointer - @hwware this hashtype was introduced in 8.1... I am not sure we should include fixes made internally between release versions in the release docs. WDYT?

[hwware]

I suggest to add the following pr:
#1721 Fix temp file leak druing replication error handling
#1785 Remove unicode optimization in Lua cjson library
#1782 valkey-cli: ensure output ends with a newline if missing when printing reply
#1760 cmd's out bytes need count deferred reply
#1799 Fix hashTypeEntryDefrag returning bad pointer
Thanks @ranshid It is a hard work.

#1721 Fix temp file leak druing replication error handling - @enjoy-binbin - should this have also been backported?

#1799 Fix hashTypeEntryDefrag returning bad pointer - @hwware this hashtype was introduced in 8.1... I am not sure we should include fixes made internally between release versions in the release docs. WDYT?

#1799 Fix hashTypeEntryDefrag returning bad pointer Sorry, for this one, I think we do not need to mention it in release note.

[ranshid]

#1799

cool. added the others

[enjoy-binbin]

#1721 Fix temp file leak druing replication error handling - @enjoy-binbin - should this have also been backported?

@ranshid you means backport to 8.1? I thought we will merge everything in unstable branch into 8.1? If you mean some older version like 8.0, that is ok to do the backport since it is pretty easy i guess and there is no harm.

[ranshid]

#1721 Fix temp file leak druing replication error handling - @enjoy-binbin - should this have also been backported?

@ranshid you means backport to 8.1? I thought we will merge everything in unstable branch into 8.1? If you mean some older version like 8.0, that is ok to do the backport since it is pretty easy i guess and there is no harm.

I did not get much into the fix, but we had dual channel since 8.0. so asking if this should be backported to 8.0?

[enjoy-binbin]

I did not get much into the fix, but we had dual channel since 8.0. so asking if this should be backported to 8.0?

I believe it has been a problem since a very old version, including ours 7.2/8.0, i found in it an old version in our fork (just doing other stuff and doing a review and then i find it), it is not about dual channel, just about the replication error handling.. The leak is minor, it should only occur if ae fails, that is, if a call like connSetReadHandler fails, which is very rare i guess.

[ranshid]

I did not get much into the fix, but we had dual channel since 8.0. so asking if this should be backported to 8.0?

I believe it has been a problem since a very old version, including ours 7.2/8.0, i found in it an old version in our fork (just doing other stuff and doing a review and then i find it), it is not about dual channel, just about the replication error handling.. The leak is minor, it should only occur if ae fails, that is, if a call like connSetReadHandler fails, which is very rare i guess.

ACK. so lets backport this fix then