Update COPY and MOVE command description clearer in JSON file #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hwware <[email protected]>
hwware
force-pushed
the
update-copy-move-command-reply-message-description
branch
from
84036f6 to
a4b5706
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1843 +/- ##
============================================
+ Coverage 71.03% 71.07% +0.03%
============================================
Files 123 123
Lines 65666 65666
============================================
+ Hits 46648 46670 +22
+ Misses 19018 18996 -22 🚀 New features to boost your workflow:
|
madolson
approved these changes
Mar 13, 2025
| @@ -82,7 +82,7 @@ | |||
| "const": 1 | |||
| }, | |||
| { | |||
| "description": "Source was not copied.", | |||
| "description": "Source was not copied when the destination key already exists", | |||
There was a problem hiding this comment.
Is this description actually used anywhere?
There was a problem hiding this comment.
The words come from our webpage https://valkey.io/commands/move/ and https://valkey.io/commands/copy/, it makes user easier to understand
There was a problem hiding this comment.
The reply text on the website comes from the doc repo resp2_replies.json and resp3_replies.json.
| @@ -52,7 +52,7 @@ | |||
| "const": 1 | |||
| }, | |||
| { | |||
| "description": "Key wasn't moved.", | |||
| "description": "When key already exists in the destination database, or it does not exist in the source database", | |||
There was a problem hiding this comment.
Lets also keep the old wording? The short one is a good wording too i think
Suggested change
| "description": "When key already exists in the destination database, or it does not exist in the source database", | |
| "description": "Key wasn't moved. When key already exists in the destination database, or it does not exist in the source database", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I do the code review for PR #1671 (Add multi-database support to cluster mode), I find
the return value message of the command COPY and MOVE is not very clear to user. Thus I update them in this PR and valkey-doc repo as PR valkey-io/valkey-doc#249