Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BYPOLYGON option for GEOSEARCH #1809

Draft
wants to merge 16 commits into
base: unstable
Choose a base branch
from

Conversation

KarthikSubbarao
Copy link
Member

@KarthikSubbarao KarthikSubbarao commented Mar 3, 2025

This is a draft PR while I examine correctness of the BYPOLYGON search described here: #1755

It is functional, however the parts remaining are validation of correctness, adding .tcl testing, and optimizing.

Keeping this in a draft state until the GitHub issue is reviewed in more detail (and agreed upon) and until the parts above are completed.

Signed-off-by: KarthikSubbarao <[email protected]>
Signed-off-by: KarthikSubbarao <[email protected]>
Signed-off-by: KarthikSubbarao <[email protected]>
…roid of polygon. We can choose to not support WITHDIST, COUNT, ASC/DESC for polygon if we want to. With this commit, we do support it

Signed-off-by: KarthikSubbarao <[email protected]>
Signed-off-by: KarthikSubbarao <[email protected]>
Signed-off-by: KarthikSubbarao <[email protected]>
Signed-off-by: KarthikSubbarao <[email protected]>
Signed-off-by: KarthikSubbarao <[email protected]>
@KarthikSubbarao KarthikSubbarao marked this pull request as draft March 3, 2025 05:38
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 25.80645% with 92 lines in your changes missing coverage. Please review.

Project coverage is 70.90%. Comparing base (f31cf18) to head (d3c8681).
Report is 1 commits behind head on unstable.

Files with missing lines Patch % Lines
src/geohash_helper.c 18.07% 68 Missing ⚠️
src/geo.c 41.46% 24 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1809      +/-   ##
============================================
- Coverage     71.04%   70.90%   -0.15%     
============================================
  Files           123      123              
  Lines         65651    65764     +113     
============================================
- Hits          46644    46632      -12     
- Misses        19007    19132     +125     
Files with missing lines Coverage Δ
src/geo.c 89.11% <41.46%> (-4.47%) ⬇️
src/geohash_helper.c 64.97% <18.07%> (-34.19%) ⬇️

... and 13 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant