Replaced temp dicts with hashtable in hrandfieldWithCountCommand. #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shai Zarka <[email protected]>
zarkash-aws
force-pushed
the
replace_temp_dicts_with_hashtable
branch
from
da5d9a1 to
d0bf28c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1550 by replacing the use of temporary dict structures with hashtable in
hrandfieldWithCountCommand.Notes:
CASE 3: Replaced sdsReplyDictType with hashHashtableType to efficiently store field-value pairs using hashTypeEntry.
CASE 4: Replaced hashDictType with setHashtableType, as only the field needs to be stored.