Consistent look and feel of licenses #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madolson
commented
Feb 27, 2025
Signed-off-by: Madelyn Olson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1788 +/- ##
============================================
+ Coverage 71.09% 71.15% +0.05%
============================================
Files 123 123
Lines 65552 65641 +89
============================================
+ Hits 46604 46704 +100
+ Misses 18948 18937 -11
|
PingXie
approved these changes
Feb 27, 2025
enjoy-binbin
approved these changes
Feb 27, 2025
|
Did you add this only to files where we have >= 100 lines changed since forking? I saw you wrote this in the guideline. |
zuiderkwast
pushed a commit
that referenced
this pull request
Mar 18, 2025
Use a consistent set of licenses for Valkey files. I took a look and applied sort of a "did we make a material change in this file?" and tried to be conservative in adding the trademark. We could also be liberal as well. Resolves: #1692. Included documentation about the licensing here: #1787. Licenses are now also always explicitly first, even about documentation files. Signed-off-by: Madelyn Olson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a consistent set of licenses for Valkey files. I took a look and applied sort of a "did we make a material change in this file?" and tried to be conservative in adding the trademark. We could also be liberal as well.
Resolves: #1692.
Included documentation about the licensing here: #1787.
Licenses are now also always explicitly first, even above documentation in files.