Change redis to server in INFO fields redis_{git_sha1,git_dirty,build_id} #1736
Conversation
… and redis_build_id Signed-off-by: Viktor Söderqvist <[email protected]>
Signed-off-by: Viktor Söderqvist <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1736 +/- ##
============================================
- Coverage 71.17% 71.10% -0.08%
============================================
Files 123 123
Lines 65536 65536
============================================
- Hits 46645 46599 -46
- Misses 18891 18937 +46
|
| "redis_git_sha1:%s\r\n", serverGitSHA1(), | ||
| "redis_git_dirty:%i\r\n", strtol(serverGitDirty(), NULL, 10) > 0, | ||
| "redis_build_id:%s\r\n", serverBuildIdString(), | ||
| "server_git_sha1:%s\r\n", serverGitSHA1(), |
There was a problem hiding this comment.
Some part of me says let's just leave them. One more thing to not list as a breaking change.
There was a problem hiding this comment.
I remember we should keep this info message as is, otherwise is a break change. For the other update in this PR, everything is fine.
There was a problem hiding this comment.
Yes, it's a breaking change.
So I think we will not change it in 9.0 then. But I'm wondering: How long are we going to keep everything 'redis'? Forever? Five years? If we keep it forever, then users will always remember that Redis was the original and Valkey is just a fork.
If we want to accept the risk, we are allowed to make breaking changes in a major version. I understand "redis_version" is used by many clients, but the git fields are likely not used by many. If we decide to change it some time, I hope users will understand that we want to phase out 'redis' named fields.
These fields were mentioned in #41 but we didn't change them. I don't remember why.
I hope we can changing them in 9.0 when we're phasing out the redis compatibility fields.