Skip to content

test(node): stabilize pubsub channels (unique runId + bounded wait) #4954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hank95179 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test(node): stabilize pubsub channels (unique runId + bounded wait) #4954

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c50874
test(node): stabilize pubsub channels (unique runId + bounded wait)
hank95179 Nov 7, 2025
cade476
Merge branch 'main' into fix/node-pubsub-channels-stabilize
xShinnRyuu Nov 13, 2025
cd42e28
Merge branch 'main' into fix/node-pubsub-channels-stabilize
xShinnRyuu Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 43 additions & 7 deletions node/tests/PubSub.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3444,10 +3444,11 @@ describe("PubSub", () => {
let client: TGlideClient | null = null;

try {
const channel1 = "test_channel1";
const channel2 = "test_channel2";
const channel3 = "some_channel3";
const pattern = "test_*";
const runId = String(getRandomKey());
const channel1 = `test_channel1:${runId}`;
const channel2 = `test_channel2:${runId}`;
const channel3 = `some_channel3:${runId}`;
const pattern = `test_*:${runId}`;

if (clusterMode) {
client = await GlideClusterClient.createClient(
Expand All @@ -3460,7 +3461,10 @@ describe("PubSub", () => {
}

// Assert no channels exists yet
expect(await client.pubsubChannels()).toEqual([]);
const none = await client.pubsubChannels({
pattern: `*:${runId}`,
});
expect(new Set(none)).toEqual(new Set([]));

pubSub = createPubSubSubscription(
clusterMode,
Expand All @@ -3482,12 +3486,44 @@ describe("PubSub", () => {
);

// Test pubsubChannels without pattern
const channels = await client2.pubsubChannels();
for (let i = 0; i < 60; i++) {
const channels = await client2.pubsubChannels({
pattern: `*:${runId}`,
});
const s = new Set(channels);

if (s.has(channel1) && s.has(channel2) && s.has(channel3)) {
break;
}

await new Promise((r) => setTimeout(r, 50));
}

const channels = await client2.pubsubChannels({
pattern: `*:${runId}`,
});
expect(new Set(channels)).toEqual(
new Set([channel1, channel2, channel3]),
);

// Test pubsubChannels with pattern
for (let i = 0; i < 60; i++) {
const channelsWithPattern = await client2.pubsubChannels({
pattern,
});
const s = new Set(channelsWithPattern);

if (
s.has(channel1) &&
s.has(channel2) &&
!s.has(channel3)
) {
break;
}

await new Promise((r) => setTimeout(r, 50));
}

const channelsWithPattern = await client2.pubsubChannels({
pattern,
});
Expand All @@ -3497,7 +3533,7 @@ describe("PubSub", () => {

// Test with non-matching pattern
const nonMatchingChannels = await client2.pubsubChannels({
pattern: "non_matching_*",
pattern: `non_matching_*:${runId}`,
});
expect(nonMatchingChannels.length).toBe(0);
} finally {
Expand Down
Loading