Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: implement support for using insecure TLS #3386

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mthemis-provenir
Copy link

Issue link

This Pull Request is linked to issue (URL): #3376

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@mthemis-provenir mthemis-provenir requested a review from a team as a code owner March 18, 2025 15:16
@avifenesh
Copy link
Member

avifenesh commented Mar 18, 2025

Thanks a lot! ❤️
@GilboaAWS Please review
@yipin-chen @jbrinkman Please assign the right team-members to review 🙏🏽

@avifenesh avifenesh added java issues and fixes related to the java client Feature Additional feature, big or small labels Mar 18, 2025
@avifenesh avifenesh added this to the 1.4 milestone Mar 18, 2025
@avifenesh
Copy link
Member

avifenesh commented Mar 18, 2025

@mthemis-provenir Please feel free to join valkey slack workspace
If you want to keep being involved in the project, please ping me there, will be happy to have you with us!

@mthemis-provenir
Copy link
Author

@mthemis-provenir Please feel free to join valkey slack workspace If you want to keep being involved in the project, please ping me there, will be happy to have you with us!

Appreciate the offer buddy, but it's a little outside of my wheelhouse. I'm a platform engineer and this tripped us up when trying to use a CNAME to point to a Valkey Serverless cluster in AWS, so I figured how hard could it be to contribute a fix in the hope we can keep using them eventually. I spend most of my time working on infrastructure as code and other platform tooling 😆

@avifenesh
Copy link
Member

@mthemis-provenir Haha I see, well, the best reason to contribute, they say.
Feel free also to join as a user, so you can have a direct way to interact if you need help.
We feel good with direct interaction, and the WS is open to all.
Anyway, we will be available here as well.

And, well, platform work is also needed here, in case you are wondering 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Additional feature, big or small java issues and fixes related to the java client
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants