Go: Implement Bitop command #3384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
…ey-glide into niharika-bitopcmd
Signed-off-by: Niharika Bhavaraju <[email protected]>
Yury-Fridlyand
approved these changes
Mar 20, 2025
… niharika-bitopcmd
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
jbrinkman
approved these changes
Mar 24, 2025
| bitopkey2 := "{bitop_test}key2" | ||
| destKey := "{bitop_test}dest" | ||
|
|
||
| // Set initial values |
There was a problem hiding this comment.
Nice use of comments to help clarify examples.
go/integTest/shared_commands_test.go
Outdated
| key2 := "{bitop_test}" + uuid.New().String() | ||
|
|
||
| _, err := client.Set(key1, "foo") | ||
| assert.Nil(suite.T(), err) |
There was a problem hiding this comment.
Would be better to use assert.NoError() in tests rather than assert.Nil(). The NoError() check is still a Nil check under the covers, but is more descriptive from a code perspective.
Signed-off-by: Niharika Bhavaraju <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go: Implement Bitop command
Issue link
This Pull Request is linked to issue : #3397