C#: CI - fix dotnet installation on mac runners #3382
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
commented
Mar 18, 2025
| # workaround for https://github.com/actions/setup-dotnet/issues/608 | ||
| - name: Fix dotnet installation on mac | ||
| if: ${{ matrix.host.OS == 'macos' }} | ||
| run: dotnet new globaljson --sdk-version ${{ matrix.dotnet }}.0 --roll-forward latestFeature |
There was a problem hiding this comment.
${{ matrix.dotnet }}.0
creates a string '8.0.0' or '6.0.0'. The last '.0' is essential.
jamesx-improving
approved these changes
Mar 18, 2025
There was a problem hiding this comment.
How urgent is this? Looks more like a workaround. If urgent we can merge this in for now while wait for actual solution/fix from the setup-dotnet issue.
|
Not urgent. Agree to keep it open intil that issue fixed or it become critical for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without creating a
global.json, dotnet didn't use correct version of SDK on mac runners.