Java: Fix `scriptKill` Flaky Tests #3364

edlng · 2025-03-14T00:20:26Z

This PR addresses the issue of flaky tests within the Java client's scriptKill and scriptKill_unkillable tests.

Issue link

This Pull Request is linked to issue (URL): #2524

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Destination branch is correct - main or release
Create merge commit if merging release branch into main, squash otherwise.

Signed-off-by: Edward Liang <[email protected]>

Yury-Fridlyand

IMO we're mostly testing the server and probably finding a workarount for a server bug.
For testing the client it is enough to complete the test on line 1715.

BTW, why promise created on lines 1716-1717 isn't used?

Yury-Fridlyand · 2025-03-15T00:32:11Z

Run this test 1000 times in CI to validate that it doesn't fail. You can do it on another branch or do it there, but revert that change once test pass.

edlng · 2025-03-17T16:04:10Z

IMO we're mostly testing the server and probably finding a workarount for a server bug. For testing the client it is enough to complete the test on line 1715.

BTW, why promise created on lines 1716-1717 isn't used?

Not too sure what this promise is used for either. Could just be a forgotten copy paste deletion

Signed-off-by: Edward Liang <[email protected]>

… tests Signed-off-by: Edward Liang <[email protected]>

.github/workflows/java.yml

Signed-off-by: Edward Liang <[email protected]>

This reverts commit c01f396. added more checking Signed-off-by: Edward Liang <[email protected]>

Signed-off-by: Edward Liang <[email protected]>

wip

10f66bd

Signed-off-by: Edward Liang <[email protected]>

edlng added java issues and fixes related to the java client testing Everything about testing Flaky-tests Flaky-tests labels Mar 14, 2025

edlng had a problem deploying to AWS_ACTIONS March 14, 2025 00:20 — with GitHub Actions Error

(wip) small fix and cleaned up code

2e161cf

Signed-off-by: Edward Liang <[email protected]>

edlng force-pushed the java/fix-script-kill-tests branch from 5762571 to 2e161cf Compare March 14, 2025 00:29

edlng had a problem deploying to AWS_ACTIONS March 14, 2025 00:29 — with GitHub Actions Error

(wip) maybe fixed unkillable flaky test

005e6f3

Signed-off-by: Edward Liang <[email protected]>

edlng had a problem deploying to AWS_ACTIONS March 14, 2025 21:11 — with GitHub Actions Error

(wip) fix lint and added details

800756e

Signed-off-by: Edward Liang <[email protected]>

edlng had a problem deploying to AWS_ACTIONS March 14, 2025 21:42 — with GitHub Actions Error

removed prints and used easier dummy command

633e145

Signed-off-by: Edward Liang <[email protected]>

edlng had a problem deploying to AWS_ACTIONS March 14, 2025 22:24 — with GitHub Actions Error

removed resetting timeouts and added thread sleeps instead

7cbe05f

Signed-off-by: Edward Liang <[email protected]>

edlng had a problem deploying to AWS_ACTIONS March 14, 2025 22:50 — with GitHub Actions Error

Merge branch 'main' into java/fix-script-kill-tests

2e4e042

edlng had a problem deploying to AWS_ACTIONS March 14, 2025 22:51 — with GitHub Actions Error

added extra timeout check before rerunning script

2be158b

Signed-off-by: Edward Liang <[email protected]>

edlng had a problem deploying to AWS_ACTIONS March 14, 2025 23:39 — with GitHub Actions Error

edlng marked this pull request as ready for review March 14, 2025 23:56

edlng requested a review from a team as a code owner March 14, 2025 23:56

Yury-Fridlyand approved these changes Mar 15, 2025

View reviewed changes

repeat tests

4e1ab13

Signed-off-by: Edward Liang <[email protected]>

edlng had a problem deploying to AWS_ACTIONS March 17, 2025 16:05 — with GitHub Actions Error

temporarily bump timeout for flaky tests

4f1c9b1

Signed-off-by: Edward Liang <[email protected]>

edlng had a problem deploying to AWS_ACTIONS March 17, 2025 16:45 — with GitHub Actions Error

(wip) added more debug logs

326d6f9

Signed-off-by: Edward Liang <[email protected]>

(wip) bump GA timeout more to ensure flakiness doesn't arise in later…

0900737

… tests Signed-off-by: Edward Liang <[email protected]>

edlng had a problem deploying to AWS_ACTIONS March 17, 2025 22:37 — with GitHub Actions Error

avifenesh reviewed Mar 18, 2025

View reviewed changes

.github/workflows/java.yml Outdated Show resolved Hide resolved

(wip) remove prints, rerun tests

6109a84

Signed-off-by: Edward Liang <[email protected]>

edlng had a problem deploying to AWS_ACTIONS March 18, 2025 17:02 — with GitHub Actions Error

edlng marked this pull request as draft March 18, 2025 17:09

run unkillable

204a423

Signed-off-by: Edward Liang <[email protected]>

edlng had a problem deploying to AWS_ACTIONS March 18, 2025 18:32 — with GitHub Actions Error

retesting script kill with less timeout

6931951

Signed-off-by: Edward Liang <[email protected]>

edlng had a problem deploying to AWS_ACTIONS March 18, 2025 20:32 — with GitHub Actions Error

make test run once

a9d42ae

Signed-off-by: Edward Liang <[email protected]>

edlng had a problem deploying to AWS_ACTIONS March 18, 2025 22:33 — with GitHub Actions Error

Merge branch 'main' into java/fix-script-kill-tests

89e3c0a

edlng marked this pull request as ready for review March 18, 2025 22:34

edlng temporarily deployed to AWS_ACTIONS March 18, 2025 22:34 — with GitHub Actions Inactive

edlng requested review from Yury-Fridlyand and jbrinkman March 18, 2025 22:34

Yury-Fridlyand approved these changes Mar 18, 2025

View reviewed changes

Merge branch 'main' into java/fix-script-kill-tests

8606747

edlng had a problem deploying to AWS_ACTIONS March 19, 2025 18:10 — with GitHub Actions Error

Merge branch 'main' into java/fix-script-kill-tests

e01de61

edlng had a problem deploying to AWS_ACTIONS March 19, 2025 18:30 — with GitHub Actions Error

added more checking

c01f396

Signed-off-by: Edward Liang <[email protected]>

edlng had a problem deploying to AWS_ACTIONS March 19, 2025 18:56 — with GitHub Actions Error

edlng had a problem deploying to AWS_ACTIONS March 19, 2025 19:30 — with GitHub Actions Error

Revert "added more checking"

e13077a

This reverts commit c01f396. added more checking Signed-off-by: Edward Liang <[email protected]>

edlng force-pushed the java/fix-script-kill-tests branch from cd69eb2 to e13077a Compare March 19, 2025 19:33

edlng had a problem deploying to AWS_ACTIONS March 19, 2025 19:33 — with GitHub Actions Error

fix lint

c05254c

Signed-off-by: Edward Liang <[email protected]>

edlng requested a deployment to AWS_ACTIONS March 19, 2025 19:47 — with GitHub Actions Waiting

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Java: Fix `scriptKill` Flaky Tests #3364

Java: Fix `scriptKill` Flaky Tests #3364

edlng commented Mar 14, 2025

Yury-Fridlyand left a comment

Yury-Fridlyand commented Mar 15, 2025

edlng commented Mar 17, 2025

Java: Fix scriptKill Flaky Tests #3364

Are you sure you want to change the base?

Java: Fix scriptKill Flaky Tests #3364

Conversation

edlng commented Mar 14, 2025

Issue link

Checklist

Yury-Fridlyand left a comment

Choose a reason for hiding this comment

Yury-Fridlyand commented Mar 15, 2025

edlng commented Mar 17, 2025

Java: Fix `scriptKill` Flaky Tests #3364

Java: Fix `scriptKill` Flaky Tests #3364