Go: Add bulk args test #3363
Merged
Go: Add bulk args test #3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jamesx-improving
approved these changes
Mar 18, 2025
|
|
||
| func (suite *GlideTestSuite) GenerateLargeUuid() string { | ||
| wantedLength := math.Pow(2, 16) | ||
| id := uuid.New().String() |
There was a problem hiding this comment.
uuid seems an overkill here. I'm OK as long as the performance is not terrible, otherwise consider math/rand or even strings.Repeat().
There was a problem hiding this comment.
It does not take that much time to run this test.
edlng
approved these changes
Mar 18, 2025
Signed-off-by: prateek-kumar-improving <[email protected]>
prateek-kumar-improving
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): [REPLACE ME]
Checklist
Before submitting the PR make sure the following are checked: