C#: Reorganize Structure #3362
C#: Reorganize Structure #3362
Conversation
X39
force-pushed
the
csharp/reorganization
branch
3 times, most recently
from
2b15406 to
406a658
Compare
|
forgot to update from upstream first, sorry |
Signed-off-by: X39 <[email protected]>
X39
force-pushed
the
csharp/reorganization
branch
from
e4d5908 to
7d34e85
Compare
Signed-off-by: X39 <[email protected]>
csharp/ReadMe.md
Outdated
There was a problem hiding this comment.
No need to rename. We will have a developer guide and a user guide, they are different.
There was a problem hiding this comment.
Also not sure PascalCase naming for readme files works. At least it is first time I see it.
I would say it goes agains common patterns and guidelines even for .NET ecosystem
https://devblogs.microsoft.com/nuget/add-a-readme-to-your-nuget-package/
https://visualstudiomagazine.com/articles/2017/02/21/vs-dotnet-code-documentation-tools-roundup.aspx
benchmarks/csharp/Program.cs
Outdated
| async (key, value) => await glide_client.Set(key, value), | ||
| () => glide_client.Dispose())); |
There was a problem hiding this comment.
I afraid whitespace changes would be blamed by the linter
benchmarks/csharp/Program.cs
Outdated
| @@ -324,4 +322,4 @@ public static async Task Main(string[] args) | |||
|
|
|||
| PrintResults(options.ResultsFile); | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Please keep blank lines at EOF
| @@ -1,6 +1,6 @@ | |||
| // Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0 | |||
|
|
|||
| namespace Tests.Integration; | |||
| namespace Valkey.Glide.UnitTests.Integration; | |||
There was a problem hiding this comment.
All tests there are truly integration tests.
Changes include accidental whitespace changes and a rename that does not yet make any sense. Also reverted naming of DEVELOPER.md in accordance with contributors.
See #3354
This is part one of the split PR