Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Add back test_update_connection_password #3357

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edlng
Copy link
Collaborator

@edlng edlng commented Mar 11, 2025

This PR adds back test_update_connection_password as a skipped test rather than a removed test. I think it would be handy in case we wanted to re-enable it in the future after finding a fix, or just to prevent having to search for it again in a pile of commits.

It was removed in #3311

Issue link

This Pull Request is linked to issue (URL): #3058

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@edlng edlng added python Python wrapper testing Everything about testing labels Mar 11, 2025
@edlng edlng requested a review from a team as a code owner March 11, 2025 23:44
@ikolomi
Copy link
Collaborator

ikolomi commented Mar 12, 2025

It seems that there is a solution for timing falkiness here #3330

Please try to apply it here and reenable if stable

Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@edlng edlng marked this pull request as draft March 12, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Python wrapper testing Everything about testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants