GO: Implement lolwut command #3355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
…key-glide into niharika-lolwutcmd
Signed-off-by: Niharika Bhavaraju <[email protected]>
Comment on lines
+25
to
+29
| func NewLolwutOptions(version int64) *LolwutOptions { | ||
| return &LolwutOptions{Version: version} | ||
| } | ||
|
|
||
| func (options *LolwutOptions) SetArgs(args []int) *LolwutOptions { |
There was a problem hiding this comment.
Please add docs to these setters
| @@ -82,3 +82,26 @@ func ExampleGlideClusterClient_DBSizeWithOptions() { | |||
|
|
|||
| // Output: 0 | |||
| } | |||
|
|
|||
| func ExampleGlideClusterClient_LolwutWithOptions() { | |||
There was a problem hiding this comment.
Need to duplicate the test for lolwut without options
| @@ -113,3 +113,28 @@ func ExampleGlideClient_InfoWithOptions() { | |||
|
|
|||
| // Output: response is of type string | |||
| } | |||
|
|
|||
| func ExampleGlideClient_LolwutWithOptions() { | |||
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GO: Implement lolwut command
Issue link
This Pull Request is linked to issue : #3396