Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: add open telemetry client config #3310

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

adarovadya
Copy link
Collaborator

@adarovadya adarovadya commented Mar 3, 2025

Issue link

This Pull Request is linked to issue (URL): (#3309)

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@adarovadya adarovadya requested a review from a team as a code owner March 3, 2025 15:31
@adarovadya adarovadya requested a review from eifrah-aws March 3, 2025 15:32
@adarovadya adarovadya self-assigned this Mar 3, 2025
@adarovadya adarovadya added the node Node.js wrapper label Mar 3, 2025
@adarovadya adarovadya added this to the 1.4 milestone Mar 3, 2025
Adar Ovadia added 2 commits March 3, 2025 16:11
@adarovadya adarovadya force-pushed the node-ot-config branch 2 times, most recently from afb5ba0 to d94a95e Compare March 3, 2025 16:51
advancedConfiguration: {
openTelemetryConfig: {
collectorEndPoint: "wrong.endpoint",
spanFlushIntervalMs: 400,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tests with negative spanFlushIntervalMs ?

Yury-Fridlyand and others added 14 commits March 6, 2025 13:25
* Update readme

---------

Signed-off-by: Yury-Fridlyand <[email protected]>
Co-authored-by: Joseph Brinkman <[email protected]>
Co-authored-by: James Xin <[email protected]>
Updated ORT allowed licenses with Unicode-3

Signed-off-by: barshaul <[email protected]>
Signed-off-by: Avi Fenesh <[email protected]>
Co-authored-by: Avi Fenesh <[email protected]>
Updated attribution files

Signed-off-by: ort-bot <[email protected]>
Co-authored-by: ort-bot <[email protected]>
* Client structure.

Signed-off-by: Yury-Fridlyand <[email protected]>
* Go: Add AzAffinity Support

Signed-off-by: TJ Zhang <[email protected]>
* Go: adding connectionTimeout

Signed-off-by: TJ Zhang <[email protected]>
Co-authored-by: TJ Zhang <[email protected]>
* add custom flags for example tests

* update example utils to use randomized ports
* don't run example tests against Redis 6.2 servers

---------

Signed-off-by: Joseph Brinkman <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
* Added cluster scan functionality

Signed-off-by: Edward Liang <[email protected]>

* Added safety docs to rust code and extra memory free command

Signed-off-by: Edward Liang <[email protected]>

* Added documentation and fixes

Signed-off-by: Edward Liang <[email protected]>

* remove leftover todo

Signed-off-by: Edward Liang <[email protected]>

* modified types

Signed-off-by: Edward Liang <[email protected]>

* included mutex changes and changelog updates

Signed-off-by: Edward Liang <[email protected]>

* added some pr fixes

Signed-off-by: Edward Liang <[email protected]>

* small fixes to docs

Signed-off-by: Edward Liang <[email protected]>

* provide support for invalid utf8 characters

Signed-off-by: Edward Liang <[email protected]>

* added better error callback

Signed-off-by: Edward Liang <[email protected]>

* removed unnecessary exposed function and added safety docs

Signed-off-by: Edward Liang <[email protected]>

* modified for scan to return cursor object

Signed-off-by: Edward Liang <[email protected]>

* fix lint

Signed-off-by: Edward Liang <[email protected]>

* fixed safety note

Signed-off-by: Edward Liang <[email protected]>

* removed unnecessary safety docs

Signed-off-by: Edward Liang <[email protected]>

* removed cursor arg as a pointer

Signed-off-by: Edward Liang <[email protected]>

---------

Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
* Shared IT.

---------

Signed-off-by: Yury-Fridlyand <[email protected]>
* Revert "Update readme - include compatibility notice (valkey-io#3262)"

This reverts commit 23ca48e.

* Cherry-pick readme update from `release-1.3` branch (valkey-io#3319).

Signed-off-by: Yury-Fridlyand <[email protected]>
* revert changes

Signed-off-by: Edward Liang <[email protected]>

* Upgraded pyo3 to 0.23

Signed-off-by: Edward Liang <[email protected]>

* Added better error messages

Signed-off-by: Edward Liang <[email protected]>

---------

Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
* Split IT suite for java client.

Signed-off-by: Yury-Fridlyand <[email protected]>
tjzhang-BQ and others added 2 commits March 6, 2025 13:25
…o#3324)

* Replacing Hash Maps in response handling with LinkedHashMap

Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: Adar Ovadia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

9 participants