-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node: add open telemetry client config #3310
Open
adarovadya
wants to merge
19
commits into
valkey-io:main
Choose a base branch
from
adarovadya:node-ot-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adar Ovadia <[email protected]>
Signed-off-by: Adar Ovadia <[email protected]>
afb5ba0
to
d94a95e
Compare
Signed-off-by: Adar Ovadia <[email protected]>
d94a95e
to
654c7e5
Compare
This was referenced Mar 3, 2025
shohamazon
reviewed
Mar 6, 2025
shohamazon
reviewed
Mar 6, 2025
shohamazon
reviewed
Mar 6, 2025
advancedConfiguration: { | ||
openTelemetryConfig: { | ||
collectorEndPoint: "wrong.endpoint", | ||
spanFlushIntervalMs: 400, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add tests with negative spanFlushIntervalMs
?
* Update readme --------- Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Joseph Brinkman <[email protected]> Co-authored-by: James Xin <[email protected]>
…valkey-io#3311) Signed-off-by: avifenesh <[email protected]> Co-authored-by: avifenesh <[email protected]>
Updated ORT allowed licenses with Unicode-3 Signed-off-by: barshaul <[email protected]> Signed-off-by: Avi Fenesh <[email protected]> Co-authored-by: Avi Fenesh <[email protected]>
Updated attribution files Signed-off-by: ort-bot <[email protected]> Co-authored-by: ort-bot <[email protected]>
* Client structure. Signed-off-by: Yury-Fridlyand <[email protected]>
* Go: Add AzAffinity Support Signed-off-by: TJ Zhang <[email protected]>
* Go: adding connectionTimeout Signed-off-by: TJ Zhang <[email protected]> Co-authored-by: TJ Zhang <[email protected]>
* add custom flags for example tests * update example utils to use randomized ports * don't run example tests against Redis 6.2 servers --------- Signed-off-by: Joseph Brinkman <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]>
* Added cluster scan functionality Signed-off-by: Edward Liang <[email protected]> * Added safety docs to rust code and extra memory free command Signed-off-by: Edward Liang <[email protected]> * Added documentation and fixes Signed-off-by: Edward Liang <[email protected]> * remove leftover todo Signed-off-by: Edward Liang <[email protected]> * modified types Signed-off-by: Edward Liang <[email protected]> * included mutex changes and changelog updates Signed-off-by: Edward Liang <[email protected]> * added some pr fixes Signed-off-by: Edward Liang <[email protected]> * small fixes to docs Signed-off-by: Edward Liang <[email protected]> * provide support for invalid utf8 characters Signed-off-by: Edward Liang <[email protected]> * added better error callback Signed-off-by: Edward Liang <[email protected]> * removed unnecessary exposed function and added safety docs Signed-off-by: Edward Liang <[email protected]> * modified for scan to return cursor object Signed-off-by: Edward Liang <[email protected]> * fix lint Signed-off-by: Edward Liang <[email protected]> * fixed safety note Signed-off-by: Edward Liang <[email protected]> * removed unnecessary safety docs Signed-off-by: Edward Liang <[email protected]> * removed cursor arg as a pointer Signed-off-by: Edward Liang <[email protected]> --------- Signed-off-by: Edward Liang <[email protected]> Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: ikolomi <[email protected]>
* Shared IT. --------- Signed-off-by: Yury-Fridlyand <[email protected]>
* Revert "Update readme - include compatibility notice (valkey-io#3262)" This reverts commit 23ca48e. * Cherry-pick readme update from `release-1.3` branch (valkey-io#3319). Signed-off-by: Yury-Fridlyand <[email protected]>
* revert changes Signed-off-by: Edward Liang <[email protected]> * Upgraded pyo3 to 0.23 Signed-off-by: Edward Liang <[email protected]> * Added better error messages Signed-off-by: Edward Liang <[email protected]> --------- Signed-off-by: Edward Liang <[email protected]> Signed-off-by: Edward Liang <[email protected]>
* Split IT suite for java client. Signed-off-by: Yury-Fridlyand <[email protected]>
…o#3324) * Replacing Hash Maps in response handling with LinkedHashMap Signed-off-by: TJ Zhang <[email protected]>
Signed-off-by: Adar Ovadia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): (#3309)
Checklist
Before submitting the PR make sure the following are checked: