Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go Implement Client Get and Set Name #3302

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Go Implement Client Get and Set Name #3302

wants to merge 27 commits into from

Conversation

EdricCua
Copy link
Collaborator

@EdricCua EdricCua commented Mar 3, 2025 •
edited by Yury-Fridlyand
Loading

Issue link

This Pull Request is linked to issue (URL): #3400

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@EdricCua EdricCua requested a review from a team as a code owner March 3, 2025 06:58
EdricCua added 10 commits March 3, 2025 07:15
@EdricCua
Update from main
d98894f 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement Client Get-Set Name
2c9c856 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement Client Get-Set Name
ad8b8e6 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement Client Get-Set Name
575a46c 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement Client Get-Set Name
df3085d 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement Client Get-Set Name
bbce65e 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement Client Get-Set Name
8f7b23b 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement Client Get-Set Name
1f23c18 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Implement Client Get-Set Name
6cb9be1 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Update from Main
2ff7059 
Signed-off-by: EdricCua <[email protected]>
@yipin-chen yipin-chen added the go golang wrapper label Mar 4, 2025
EdricCua added 7 commits March 5, 2025 07:42
@EdricCua
Fix commit issues
744d2a8 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix merge conflict
9017462 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix commit errors
bc93b24 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix commit errors
dfb7d8c 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix commit error
2942f3a 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix CI Job
a767ee1 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Update from main
ea9cde6 
Signed-off-by: EdricCua <[email protected]>
Yury-Fridlyand
Yury-Fridlyand reviewed Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry and update PR description by adding a correct issue link

EdricCua added 3 commits March 20, 2025 01:33
@EdricCua
fix examples
8342eff 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix examples
d7a53c8 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
update from main
d394099 
Signed-off-by: EdricCua <[email protected]>
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Mar 20, 2025
Open
4 tasks
Yury-Fridlyand
Yury-Fridlyand approved these changes Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming last comments are also addresed

EdricCua added 2 commits March 20, 2025 21:54
@EdricCua
update from main
5670a71 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix review comment
1dc63b8 
Signed-off-by: EdricCua <[email protected]>
@EdricCua EdricCua requested a review from jbrinkman March 20, 2025 22:39
Yury-Fridlyand
Yury-Fridlyand reviewed Mar 21, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed those in previous review

@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Mar 21, 2025
Open
3 tasks
EdricCua added 3 commits March 21, 2025 03:40
@EdricCua
fix review comment
70acc8f 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
update from main
3d1eafe 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
update from main
9b8bc52 
Signed-off-by: EdricCua <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@prateek-kumar-improving prateek-kumar-improving prateek-kumar-improving approved these changes

@jbrinkman jbrinkman Awaiting requested review from jbrinkman

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EdricCua @Yury-Fridlyand @prateek-kumar-improving @yipin-chen