Skip to content

C#: Reorganize client structure. #3283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Feb 27, 2025

Reorganize client classes according to the design:

image

(silimar to what we have in java and go)

Docs:
image
image
for an arg:
image

Issue link

This Pull Request is linked to issue (URL): #216

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added the C# C# wrapper label Feb 27, 2025
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner February 27, 2025 04:00
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Mar 1, 2025
85 tasks
Copy link
Collaborator

@Sa1Gur Sa1Gur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Mar 4, 2025
12 tasks
Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@Yury-Fridlyand Yury-Fridlyand merged commit 94e2ce9 into valkey-io:main Mar 4, 2025
15 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the csharp/yuryf-client-structure branch March 4, 2025 16:59
adarovadya pushed a commit to adarovadya/glide-for-redis that referenced this pull request Mar 6, 2025
* Client structure.

Signed-off-by: Yury-Fridlyand <[email protected]>
liorsve pushed a commit to liorsve/valkey-glide that referenced this pull request Mar 30, 2025
* Client structure.

Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# C# wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants