Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Implement Cluster ConfigGet and ConfigSet #3274

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Go: Implement Cluster ConfigGet and ConfigSet #3274

wants to merge 24 commits into from

Conversation

EdricCua
Copy link
Collaborator

@EdricCua EdricCua commented Feb 26, 2025 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #3399

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@EdricCua EdricCua requested a review from a team as a code owner February 26, 2025 08:26
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Feb 26, 2025
@EdricCua
Add Example
8833c43 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Add examples
c1ea281 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Add examples
626c585 
Signed-off-by: EdricCua <[email protected]>
Yury-Fridlyand
Yury-Fridlyand reviewed Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is read
Please add changelog entry

EdricCua added 6 commits March 18, 2025 17:01
@EdricCua
Update from main
7cd8f30 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix CI Job
fdccffe 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix CI Job
de8a991 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix CI Job
3c1fe52 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix lint
cbb2c83 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix lint
dd6b7ba 
Signed-off-by: EdricCua <[email protected]>
Yury-Fridlyand
Yury-Fridlyand reviewed Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry and update PR description by adding a correct issue link.
Fix CI failures.

EdricCua added 6 commits March 20, 2025 02:53
@EdricCua
update from main
682d8a7 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix example
37378c0 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix example
24fbcb4 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix example
4074e11 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix test
5f16867 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix test
b5c8b44 
Signed-off-by: EdricCua <[email protected]>
Yury-Fridlyand
Yury-Fridlyand reviewed Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last minor changes and you're good to go

@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Mar 20, 2025
Open
4 tasks
@EdricCua
update from main
36831b9 
Signed-off-by: EdricCua <[email protected]>
@EdricCua EdricCua requested a review from Yury-Fridlyand March 20, 2025 22:50
@EdricCua
fix review comment
17f81a0 
Signed-off-by: EdricCua <[email protected]>
@EdricCua EdricCua requested a review from jbrinkman March 20, 2025 23:24
Yury-Fridlyand
Yury-Fridlyand reviewed Mar 21, 2025
View reviewed changes
EdricCua and others added 3 commits March 21, 2025 01:53
@EdricCua
fix review comment
b4e9673 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
update from main
f1679eb 
Signed-off-by: EdricCua <[email protected]>
@Yury-Fridlyand
Update go/api/glide_cluster_client.go
0fb3a59 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Copy link
Collaborator

Please add these commands to standalone client too (could be in another PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@jbrinkman jbrinkman Awaiting requested review from jbrinkman

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdricCua @Yury-Fridlyand