Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Implement Config Rewrite #3156

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Go: Implement Config Rewrite #3156

wants to merge 31 commits into from

Conversation

EdricCua
Copy link
Collaborator

@EdricCua EdricCua commented Feb 13, 2025 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #3399

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@EdricCua
Implement Rewrite
267b000 
Signed-off-by: EdricCua <[email protected]>
@EdricCua EdricCua requested a review from a team as a code owner February 13, 2025 00:27
jbrinkman
jbrinkman reviewed Feb 13, 2025
View reviewed changes
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Feb 15, 2025
Yury-Fridlyand
Yury-Fridlyand previously requested changes Feb 15, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Need to move examples to the corresponding file(s).
  2. Need to add a changelog entry as of now.
  3. RouteOption was reworked in 1.3 branch.

Please wait for backporting all changes from release-1.3 branch. You can merge/rebase you branch after that and implement required fixes.

UPD backported in #3202

EdricCua added 5 commits March 4, 2025 11:59
@EdricCua
Add Example Doc
5f0e614 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Updates from main
208a2c4 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix review comment
05b8e69 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Remove main.go
f77befd 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
update from main
15d6446 
Signed-off-by: EdricCua <[email protected]>
Yury-Fridlyand
Yury-Fridlyand reviewed Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry and update PR description by adding a correct issue link.
Fix CI failures.

EdricCua added 5 commits March 18, 2025 22:53
@EdricCua
fix review comment
7724d59 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
update from main
652df62 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix examples
4f303aa 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix examples
d04cee9 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix test
0679680 
Signed-off-by: EdricCua <[email protected]>
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Mar 20, 2025
Open
4 tasks
@EdricCua EdricCua requested a review from Yury-Fridlyand March 20, 2025 22:49
@EdricCua
update from main
6301745 
Signed-off-by: EdricCua <[email protected]>
Yury-Fridlyand
Yury-Fridlyand reviewed Mar 21, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelong and fix CI

EdricCua added 10 commits March 21, 2025 01:32
@EdricCua
fix test
01254b7 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix test
6d9a7e7 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
update from main
699d46f 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix docs
9768199 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix unit test
d1f2e29 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix unit test
4528c4e 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix unit test
dec046f 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix unit test
ebbb0cd 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix unit test
a823003 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix unit test
0609398 
Signed-off-by: EdricCua <[email protected]>
EdricCua added 9 commits March 21, 2025 16:30
@EdricCua
fix unit test
cb32f89 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix unit test
a4375f9 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix unit test
f6d92b3 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix unit test
33939f8 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix unit test
af7bbcf 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix unit test
7de14cb 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix unit test
683681c 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix unit test
1b6a164 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix unit test
16bbe89 
Signed-off-by: EdricCua <[email protected]>
Yury-Fridlyand
Yury-Fridlyand reviewed Mar 23, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog

go/integTest/cluster_commands_test.go
}
}
if len(configFile) > 0 {
fmt.Println("ConfigFile: ", configFile)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove debug prints

@Yury-Fridlyand Yury-Fridlyand dismissed their stale review March 23, 2025 01:37

almost all fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrinkman jbrinkman jbrinkman left review comments

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdricCua @jbrinkman @Yury-Fridlyand