Go: Implement PfMerge command #3082
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niharika Bhavaraju <[email protected]>
omangesg
reviewed
Feb 5, 2025
| // | ||
| // [valkey.io]: https://valkey.io/commands/pfmerge/ | ||
| func (client *baseClient) PfMerge(destination string, sourceKeys []string) (string, error) { | ||
| result, err := client.executeCommand(C.PfMerge, append([]string{destination}, sourceKeys...)) |
There was a problem hiding this comment.
Can we check if at-least one sourceKey is as PFMerge require at least one source key and this would lead to anyhow failure and will waste one network call, we can use something like this :-
if len(sourceKeys) == 0 {
return "", errors.New("at least one source key is required for PfMerge")
}
There was a problem hiding this comment.
No need, we don't do this in other commands/clients
There was a problem hiding this comment.
But adding this check will make the execution of command more efficient isn't it, and if other clients have not implemented such behavior, it seems a miss because anyhow the execution of command is going to fail.
go/api/base_client.go
Outdated
Comment on lines
3615
to
3622
| // Note: | ||
| // | ||
| // In cluster mode, if keys in `keyValueMap` map to different hash slots, the command | ||
| // will be split across these slots and executed separately for each. This means the command | ||
| // is atomic only at the slot level. If one or more slot-specific requests fail, the entire | ||
| // call will return the first encountered error, even though some requests may have succeeded | ||
| // while others did not. If this behavior impacts your application logic, consider splitting | ||
| // the request into sub-requests per slot to ensure atomicity. |
There was a problem hiding this comment.
There should be another cross-slot notice. If keys mapped to different slots, command fails.
Signed-off-by: Niharika Bhavaraju <[email protected]>
Yury-Fridlyand
approved these changes
Feb 11, 2025
Yury-Fridlyand
requested changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go: Implement PfMerge command