Skip to content

Go: Implement ClientId #3077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Mar 26, 2025
Merged

Go: Implement ClientId #3077

merged 32 commits into from
Mar 26, 2025

Conversation

EdricCua
Copy link
Contributor

@EdricCua EdricCua commented Feb 5, 2025 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #3400

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@EdricCua
Implement CLientID
e4e90a1 
Signed-off-by: EdricCua <[email protected]>
@EdricCua EdricCua requested a review from a team as a code owner February 5, 2025 00:33
@EdricCua
Implement CLientID
f1a2de4 
Signed-off-by: EdricCua <[email protected]>
omangesg
omangesg reviewed Feb 5, 2025
View reviewed changes
@Yury-Fridlyand Yury-Fridlyand added the go 🏃 golang wrapper label Feb 5, 2025
Yury-Fridlyand
Yury-Fridlyand reviewed Feb 5, 2025
View reviewed changes
Yury-Fridlyand
Yury-Fridlyand requested changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update command example to match new example template (see developer doc and/or other commands)
Add a changelog entry

@EdricCua
Add ClientID
adad091 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Add ClientID
d99f047 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
get update from main
6d3857d 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Added example doc
e040f76 
Signed-off-by: EdricCua <[email protected]>
Yury-Fridlyand
Yury-Fridlyand reviewed Mar 4, 2025
View reviewed changes
EdricCua added 7 commits March 12, 2025 19:13
@EdricCua
update from main
3e1cfbb 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix lint
679b237 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix lint
cd50ddd 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
update from main
46c2be2 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Updates from main
6d497a5 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix review comment
708a7bc 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Update from main
c328ab5 
Signed-off-by: EdricCua <[email protected]>
Yury-Fridlyand
Yury-Fridlyand reviewed Mar 18, 2025
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry and update PR description by adding a correct issue link.
Fix CI failures.

EdricCua added 4 commits March 20, 2025 02:37
@EdricCua
update from main
23fe10f 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
update from main
e7c0128 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
update from main
0f5766b 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
update from main
959f642 
Signed-off-by: EdricCua <[email protected]>
@EdricCua EdricCua requested a review from Yury-Fridlyand March 20, 2025 22:49
@EdricCua EdricCua requested a review from jbrinkman March 20, 2025 22:49
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Mar 21, 2025
Closed
3 tasks
EdricCua added 3 commits March 21, 2025 01:46
@EdricCua
fix review comment
ce585d8 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
update from main
e6814f5 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix review comment
1745747 
Signed-off-by: EdricCua <[email protected]>
Yury-Fridlyand
Yury-Fridlyand reviewed Mar 21, 2025
View reviewed changes
EdricCua added 4 commits March 21, 2025 02:11
@EdricCua
update from main
f7e79e0 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix review comment
894c510 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
Fix test
d3155c0 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
fix docs
b264776 
Signed-off-by: EdricCua <[email protected]>
@EdricCua EdricCua requested a review from Yury-Fridlyand March 21, 2025 09:55
jbrinkman
jbrinkman approved these changes Mar 23, 2025
View reviewed changes
Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

EdricCua added 2 commits March 24, 2025 20:05
@EdricCua
update from main
a69b613 
Signed-off-by: EdricCua <[email protected]>
@EdricCua
update from main
d000e7c 
Signed-off-by: EdricCua <[email protected]>
@niharikabhavaraju niharikabhavaraju merged commit 2b908ac into valkey-io:main Mar 26, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omangesg omangesg omangesg left review comments

@jbrinkman jbrinkman jbrinkman approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

Assignees
No one assigned
Labels
go 🏃 golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EdricCua @jbrinkman @Yury-Fridlyand @omangesg @niharikabhavaraju