-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Java: Shadow netty
dependencies. - breaking change
#3004
Draft
Yury-Fridlyand
wants to merge
9
commits into
main
Choose a base branch
from
java/shadow-netty
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
TODO: review netty/netty#6665 to confirm that we don't need more changes |
It seems we need to rename the .so files that get bundled in META-INF/native to have the same prefix was the shaded artifacts per: netty/netty#6665 |
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
netty
dependencies.netty
dependencies. - breaking change
…adow-netty Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
breaking changes
dependency
Dependency management
java
issues and fixes related to the java client
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3367
TODO:
This PR also includes validation of exported symbols (via
modules-info.java
in IT). Corresponding fixes were made to pass the check.Following #2931, shadowing netty deps
List of packages being shadowed:
This fix is breaking, because feature of customizing the netty thread pool was removed. All classes/files and corresponding tests were removed.
Package files:
valkey-glide-255.255.255.module.json
valkey-glide-255.255.255.pom.txt
valkey-glide-255.255.255-linux-x86_64.jar.zip
Jar content