-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to reference glide-rs as a separate external package - Yarn fix #2943
Draft
Muhammad-awawdi-amazon
wants to merge
6
commits into
valkey-io:main
Choose a base branch
from
Muhammad-awawdi-amazon:yarn-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactor to reference glide-rs as a separate external package - Yarn fix #2943
Muhammad-awawdi-amazon
wants to merge
6
commits into
valkey-io:main
from
Muhammad-awawdi-amazon:yarn-fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you please document your changes by updating PR description. What packages are published, what dependency do they have?
Consider adding an example app which uses yarn.
376dd7c
to
3ed65fe
Compare
Signed-off-by: Muhammad Awawdi <[email protected]>
Signed-off-by: Muhammad Awawdi <[email protected]>
Signed-off-by: Muhammad Awawdi <[email protected]>
Signed-off-by: Muhammad Awawdi <[email protected]>
Signed-off-by: Muhammad Awawdi <[email protected]>
23d5443
to
8782e11
Compare
Signed-off-by: Muhammad Awawdi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/CD
CI/CD related
node
Node.js wrapper
User issue
Issue openned by users
Users Pain
An issue known to cause users pain, generaly open by the user.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Yarn interprets the 'file:rust-client' path relative to the user's working directory instead of the package's actual location, which causes the dependency resolution to fail.
Desired Architecture
Base Package (Node.js Code)
Should be published as a standalone package
Contains platform-independent Node.js code
Only needs to be published once since it's not architecture-specific
Serves as the main entry point for users
Rust Client Package
Should be published separately for each platform/architecture
Contains the architecture-specific binaries
Needs multiple versions:
One for each supported operating system (Linux, MacOS, etc.)
One for each supported CPU architecture (x64, arm64, etc.)
Includes its own package.json for version management
Gets published multiple times to support different platforms
Issue link
This Pull Request is linked to issue (URL): #2680
Checklist
Before submitting the PR make sure the following are checked: