Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ort fixup #2579

Draft
wants to merge 79 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
79 commits
Select commit Hold shift + click to select a range
fcc6001
Python: adds JSON.ARRLEN command (#2403)
shohamazon Oct 10, 2024
a2ea32e
Python: adds JSON.CLEAR command (#2418)
shohamazon Oct 10, 2024
8fea303
Python [FT.CREATE] command added(Created for release-1.2 branch) (#2426)
prateek-kumar-improving Oct 11, 2024
bbfce44
Java: `FT.CREATE` (#2414)
Yury-Fridlyand Oct 11, 2024
855bb33
Added inflightRequestsLimit client config to java (#2443)
GilboaAWS Oct 13, 2024
705b404
Fix CI failing (#2444)
shohamazon Oct 13, 2024
3661f87
Fix mypy failing (#2453)
shohamazon Oct 14, 2024
9d953d3
Make redis-rs part of this repo (#2456)
eifrah-aws Oct 15, 2024
1b3cad3
Python: add JSON.NUMINCRBY command (#2448)
Muhammad-awawdi-amazon Oct 15, 2024
04f0910
Added inflightRequestsLimit client config to Node (#2452)
GilboaAWS Oct 15, 2024
b255189
Java: Allow to run modules CI on demand. (#2416)
Yury-Fridlyand Oct 15, 2024
23a180b
Python FT.DROPINDEX command (#2437)
prateek-kumar-improving Oct 15, 2024
e51aa6d
Update routing for commands from server modules. (#2461)
Yury-Fridlyand Oct 15, 2024
9b9ccdb
Java: `FT.DROPINDEX`. (#2440)
Yury-Fridlyand Oct 15, 2024
db785c9
Python: Adds JSON.NUMMULTBY Command (#2458)
Muhammad-awawdi-amazon Oct 16, 2024
15d57b2
`redis-rs` code cleanup: keep a single async runtime: `tokio` (#2459)
eifrah-aws Oct 16, 2024
1b6db03
Fix python CI: fix linter installation (#2465)
Yury-Fridlyand Oct 16, 2024
c252cbb
Java: `FT.SEARCH` (#2439)
Yury-Fridlyand Oct 17, 2024
1125eba
Python: Add commands `FT.ALIASADD`, `FT.ALIASDEL`, `FT.ALIASUPDATE` (…
prateek-kumar-improving Oct 17, 2024
adcc76f
Java: add JSON.SET and JSON.GET (#2462)
jamesx-improving Oct 17, 2024
fa12563
Node: Add CI support for server modules (#2472)
tjzhang-BQ Oct 18, 2024
87412e8
Java: `FT.AGGREGATE`. (#2468)
Yury-Fridlyand Oct 18, 2024
d291d87
Java: add `FT.INFO` (#2405)
Yury-Fridlyand Oct 18, 2024
b168972
Java: FT.ALIASADD, FT.ALIASDEL, FT.ALIASUPDATE (#2442)
cyip10 Oct 18, 2024
91cafe8
Node: add commands JSON.GET and JSON.SET (#2427)
tjzhang-BQ Oct 18, 2024
56b4401
Java: `JSON.ARRINSERT` and `JSON.ARRLEN` (#2476)
Yury-Fridlyand Oct 19, 2024
6a3a33f
Run CI on PR merge on release branches (#2475)
Yury-Fridlyand Oct 20, 2024
914fd60
Avoid retrying on IO errors when it’s unclear if the server received …
barshaul Oct 21, 2024
695697a
Rust - code cleanup, part 1 (#2478)
avifenesh Oct 21, 2024
76f68a6
Java: add JSON.ARRAPPEND command (#2489)
yipin-chen Oct 21, 2024
ee0f86f
Fix python CI (#2487)
Yury-Fridlyand Oct 22, 2024
9073eb0
Python: Add `FT.SEARCH` command (#2470)
prateek-kumar-improving Oct 22, 2024
3642038
Glide-core UDS Socket Handling Rework:
ikolomi Oct 21, 2024
f977b91
Java: add JSON.DEL and JSON.FORGET (#2490)
jamesx-improving Oct 22, 2024
f65b0fe
Node: Add command JSON.TOGGLE (#2491)
tjzhang-BQ Oct 22, 2024
bea5434
Java: fix IT (#2497)
Yury-Fridlyand Oct 22, 2024
0a11fde
Python `FT.INFO` command added (#2494)
prateek-kumar-improving Oct 22, 2024
ebf6460
Ci/redis rs (#2488)
avifenesh Oct 23, 2024
78c927b
Node: add `FT.CREATE` command (#2501)
acarbonetto Oct 23, 2024
71257a7
Java: add JSON.TOGGLE command (#2504)
yipin-chen Oct 23, 2024
fb8a63b
Node: Add command JSON.DEL and JSON.FORGET (#2505)
tjzhang-BQ Oct 23, 2024
63c225b
Minor update for node build (#2393)
Yury-Fridlyand Oct 24, 2024
b44368e
Java: `JSON.OBJLEN` and `JSON.OBJKEYS`. (#2492)
Yury-Fridlyand Oct 24, 2024
50786a3
FT.EXPLAIN and FT.EXPLAINCLI commands added (#2508)
prateek-kumar-improving Oct 24, 2024
f19976b
Node: Add command JSON.TYPE (#2510)
tjzhang-BQ Oct 24, 2024
b13535a
Docs: Update `ft.create` docs for Java and Python (#2512)
acarbonetto Oct 24, 2024
a3fbf8f
Node: add `FT.DROPINDEX` command (#2516)
acarbonetto Oct 25, 2024
f434b79
Java: add JSON.RESP (#2513)
jamesx-improving Oct 25, 2024
826bb08
Java: add JSON.ARRTRIM command (#2518)
yipin-chen Oct 25, 2024
e2c3b8a
Java: `JSON.CLEAR`. (#2519)
Yury-Fridlyand Oct 25, 2024
190939d
Rc 1.2 fix (#2503)
avifenesh Oct 26, 2024
8d09a1c
Python: adds JSON.STRLEN, JSON.STRAPPEND commands (#2372)
shohamazon Oct 27, 2024
d712983
Python: adds JSON.OBJKEYS command (#2395)
shohamazon Oct 27, 2024
08cce19
Python: adds JSON.ARRINSERT command
shohamazon Oct 16, 2024
a99d89a
Python: reorder json.py commands
shohamazon Oct 27, 2024
d95040c
Python: add JSON.DEBUG.FIELDS and JSON.DEBUG.MEMORY commands (#2481)
Muhammad-awawdi-amazon Oct 27, 2024
c197f1d
Python: adds JSON.ARRTRIM command (#2457)
shohamazon Oct 27, 2024
52dd474
Python - Implement JSON.OBJLEN command functionality (#2495)
BoazBD Oct 28, 2024
98df691
Java: `JSON.ARRPOP`. (#2486)
Yury-Fridlyand Oct 28, 2024
cb21081
Java: `FT.PROFILE` (#2473)
Yury-Fridlyand Oct 28, 2024
a882b1f
Java: `JSON.DEBUG`. (#2520)
Yury-Fridlyand Oct 28, 2024
01308db
Node: Add command JSON.RESP (#2517)
tjzhang-BQ Oct 28, 2024
5cf72b1
CI: Minor fixes (#2333)
Yury-Fridlyand Oct 28, 2024
7db739e
Java: add JSON.STRAPPEND and JSON.STRLEN (#2522)
jonathanl-bq Oct 28, 2024
5e86b7a
Java: add JSON.NUMINCRBY and JSON.NUMMULTBY (#2511)
jonathanl-bq Oct 28, 2024
ddca067
Java: FT.EXPLAIN and FT.EXPLAINCLI (#2515)
cyip10 Oct 28, 2024
7b5b72d
Python: FT.AGGREGATE command added (#2530)
prateek-kumar-improving Oct 29, 2024
53743a9
Java: add JSON.TYPE (#2525)
jamesx-improving Oct 29, 2024
1e0476c
Python: adds JSON.ARRAPPEND command (#2382)
shohamazon Oct 29, 2024
2284c75
Python: adds JSON.RESP command (#2451)
shohamazon Oct 29, 2024
ff39238
Java: Fix script kill IT (#2523)
Yury-Fridlyand Oct 29, 2024
4af45f8
Add node REPL (#2355)
Yury-Fridlyand Oct 29, 2024
5b90096
Python: Add JSON.ARRINDEX Command (#2528)
Muhammad-awawdi-amazon Oct 30, 2024
d4ef3c3
Node: `FT.INFO` (#2540)
Yury-Fridlyand Oct 30, 2024
8ef77b6
Node: Add command JSON.STRLEN and JSON.STRAPPEND (#2537)
tjzhang-BQ Oct 30, 2024
6b06138
Node: `JSON.ARRINSERT`, `JSON.ARRPOP` and `JSON.ARRLEN`. (#2542)
Yury-Fridlyand Oct 31, 2024
d598e24
Fixes https://github.com/valkey-io/valkey-glide/issues/2556 : Mutable…
ikolomi Oct 31, 2024
135026b
WIP
ikolomi Nov 3, 2024
aa36d66
WIP
ikolomi Nov 3, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 38 additions & 10 deletions .github/json_matrices/build-matrix.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,27 @@
"RUNNER": "ubuntu-latest",
"ARCH": "x64",
"TARGET": "x86_64-unknown-linux-gnu",
"PACKAGE_MANAGERS": ["pypi", "npm", "maven"]
"PACKAGE_MANAGERS": [
"pypi",
"npm",
"maven"
]
},
{
"OS": "ubuntu",
"NAMED_OS": "linux",
"RUNNER": ["self-hosted", "Linux", "ARM64"],
"RUNNER": [
"self-hosted",
"Linux",
"ARM64"
],
"ARCH": "arm64",
"TARGET": "aarch64-unknown-linux-gnu",
"PACKAGE_MANAGERS": ["pypi", "npm", "maven"],
"PACKAGE_MANAGERS": [
"pypi",
"npm",
"maven"
],
"CONTAINER": "2_28"
},
{
Expand All @@ -22,34 +34,50 @@
"RUNNER": "macos-12",
"ARCH": "x64",
"TARGET": "x86_64-apple-darwin",
"PACKAGE_MANAGERS": ["pypi", "npm", "maven"]
"PACKAGE_MANAGERS": [
"pypi",
"npm",
"maven"
]
},
{
"OS": "macos",
"NAMED_OS": "darwin",
"RUNNER": "macos-latest",
"ARCH": "arm64",
"TARGET": "aarch64-apple-darwin",
"PACKAGE_MANAGERS": ["pypi", "npm", "maven"]
"PACKAGE_MANAGERS": [
"pypi",
"npm",
"maven"
]
},
{
"OS": "ubuntu",
"NAMED_OS": "linux",
"ARCH": "arm64",
"TARGET": "aarch64-unknown-linux-musl",
"RUNNER": ["self-hosted", "Linux", "ARM64"],
"IMAGE": "node:alpine",
"RUNNER": [
"self-hosted",
"Linux",
"ARM64"
],
"IMAGE": "node:lts-alpine3.19",
"CONTAINER_OPTIONS": "--user root --privileged --rm",
"PACKAGE_MANAGERS": ["npm"]
"PACKAGE_MANAGERS": [
"npm"
]
},
{
"OS": "ubuntu",
"NAMED_OS": "linux",
"ARCH": "x64",
"TARGET": "x86_64-unknown-linux-musl",
"RUNNER": "ubuntu-latest",
"IMAGE": "node:alpine",
"IMAGE": "node:lts-alpine3.19",
"CONTAINER_OPTIONS": "--user root --privileged",
"PACKAGE_MANAGERS": ["npm"]
"PACKAGE_MANAGERS": [
"npm"
]
}
]
2 changes: 1 addition & 1 deletion .github/workflows/build-node-wrapper/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ inputs:
required: true
engine-version:
description: "Engine version to install"
required: true
required: false
type: string
publish:
description: "Enable building the wrapper in release mode"
Expand Down
22 changes: 12 additions & 10 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,20 @@ name: "CodeQL"
on:
push:
branches:
- "main"
- "v.?[0-9]+.[0-9]+.[0-9]+"
- "v.?[0-9]+.[0-9]+"
- "v?[0-9]+.[0-9]+.[0-9]+"
- "v?[0-9]+.[0-9]+"
- "main"
- "v.?[0-9]+.[0-9]+.[0-9]+"
- "v.?[0-9]+.[0-9]+"
- "v?[0-9]+.[0-9]+.[0-9]+"
- "v?[0-9]+.[0-9]+"
- release-*
pull_request:
branches:
- "main"
- "v.?[0-9]+.[0-9]+.[0-9]+"
- "v.?[0-9]+.[0-9]+"
- "v?[0-9]+.[0-9]+.[0-9]+"
- "v?[0-9]+.[0-9]+"
- "main"
- "v.?[0-9]+.[0-9]+.[0-9]+"
- "v.?[0-9]+.[0-9]+"
- "v?[0-9]+.[0-9]+.[0-9]+"
- "v?[0-9]+.[0-9]+"
- release-*
schedule:
- cron: "37 18 * * 6"

Expand Down
15 changes: 8 additions & 7 deletions .github/workflows/csharp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,14 @@ name: C# tests

on:
push:
branches: ["main"]
branches:
- main
- release-*
- v*
paths:
- csharp/**
- glide-core/src/**
- submodules/**
- glide-core/redis-rs/redis/src/**
- .github/workflows/csharp.yml
- .github/workflows/install-shared-dependencies/action.yml
- .github/workflows/test-benchmark/action.yml
Expand All @@ -17,7 +20,7 @@ on:
paths:
- csharp/**
- glide-core/src/**
- submodules/**
- glide-core/redis-rs/redis/src/**
- .github/workflows/csharp.yml
- .github/workflows/install-shared-dependencies/action.yml
- .github/workflows/test-benchmark/action.yml
Expand Down Expand Up @@ -73,8 +76,7 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
submodules: recursive


- name: Set up dotnet ${{ matrix.dotnet }}
uses: actions/setup-dotnet@v4
Expand Down Expand Up @@ -119,8 +121,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: recursive


- uses: ./.github/workflows/lint-rust
with:
Expand Down
15 changes: 8 additions & 7 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@ name: Go CI

on:
push:
branches: [ "main" ]
branches:
- main
- release-*
- v*
paths:
- glide-core/src/**
- submodules/**
- glide-core/redis-rs/redis/src/**
- go/**
- .github/workflows/go.yml
- .github/workflows/install-shared-dependencies/action.yml
Expand All @@ -16,7 +19,7 @@ on:
pull_request:
paths:
- glide-core/src/**
- submodules/**
- glide-core/redis-rs/redis/src/**
- go/**
- .github/workflows/go.yml
- .github/workflows/install-shared-dependencies/action.yml
Expand Down Expand Up @@ -70,8 +73,7 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
submodules: recursive


- name: Set up Go ${{ matrix.go }}
uses: actions/setup-go@v5
Expand Down Expand Up @@ -201,8 +203,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: recursive


- uses: ./.github/workflows/lint-rust
with:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/install-redis/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ runs:
shell: bash

- uses: actions/checkout@v4
with:
submodules: recursive


- uses: actions/cache@v3
id: cache-redis
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/install-shared-dependencies/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,9 @@ inputs:
- aarch64-unknown-linux-musl
- x86_64-unknown-linux-musl
engine-version:
description: "Engine version to install"
required: true
type: string

description: "Engine version to install"
required: false
type: string
github-token:
description: "GITHUB_TOKEN, GitHub App installation access token"
required: true
Expand All @@ -40,7 +39,7 @@ runs:
if: "${{ inputs.os == 'macos' }}"
run: |
brew update
brew install git gcc pkgconfig openssl coreutils
brew install git openssl coreutils

- name: Install software dependencies for Ubuntu GNU
shell: bash
Expand Down Expand Up @@ -72,6 +71,7 @@ runs:
github-token: ${{ inputs.github-token }}

- name: Install Valkey
if: ${{ inputs.engine-version != '' }}
uses: ./.github/workflows/install-valkey
with:
engine-version: ${{ inputs.engine-version }}
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/java-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ jobs:
echo "No cleaning needed"
fi
- uses: actions/checkout@v4
with:
submodules: recursive


- name: Set up JDK
uses: actions/setup-java@v4
Expand Down Expand Up @@ -225,8 +224,7 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
with:
submodules: recursive


- name: Set up JDK
uses: actions/setup-java@v4
Expand Down
22 changes: 11 additions & 11 deletions .github/workflows/java.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@ name: Java CI

on:
push:
branches: ["main"]
branches:
- main
- release-*
- v*
paths:
- glide-core/src/**
- submodules/**
- glide-core/redis-rs/redis/src/**
- java/**
- .github/workflows/java.yml
- .github/workflows/install-shared-dependencies/action.yml
Expand All @@ -16,7 +19,7 @@ on:
pull_request:
paths:
- glide-core/src/**
- submodules/**
- glide-core/redis-rs/redis/src/**
- java/**
- .github/workflows/java.yml
- .github/workflows/install-shared-dependencies/action.yml
Expand Down Expand Up @@ -71,8 +74,7 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
submodules: recursive


- uses: gradle/actions/wrapper-validation@v3

Expand Down Expand Up @@ -188,27 +190,25 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
submodules: recursive


- uses: ./.github/workflows/lint-rust
with:
cargo-toml-folder: ./java
name: lint java rust

test-modules:
if: github.event.pull_request.head.repo.owner.login == 'valkey-io'
if: (github.repository_owner == 'valkey-io' && github.event_name == 'workflow_dispatch') || github.event.pull_request.head.repo.owner.login == 'valkey-io'
environment: AWS_ACTIONS
name: Running Module Tests
name: Modules Tests
runs-on: [self-hosted, linux, ARM64]
timeout-minutes: 15
steps:
- name: Setup self-hosted runner access
run: sudo chown -R $USER:$USER /home/ubuntu/actions-runner/_work/valkey-glide

- uses: actions/checkout@v4
with:
submodules: recursive


- name: Set up JDK
uses: actions/setup-java@v4
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/lint-rust/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,14 @@ runs:

steps:
- uses: actions/checkout@v4
with:
submodules: recursive


- name: Install Rust toolchain and protoc
uses: ./.github/workflows/install-rust-and-protoc
with:
github-token: ${{ inputs.github-token }}

- uses: Swatinem/rust-cache@v2
with:
github-token: ${{ inputs.github-token }}

- run: cargo fmt --all -- --check
working-directory: ${{ inputs.cargo-toml-folder }}
Expand All @@ -42,7 +39,7 @@ runs:

- run: |
cargo update
cargo install --locked --version 0.15.1 cargo-deny
cargo install --locked cargo-deny
cargo deny check --config ${GITHUB_WORKSPACE}/deny.toml
working-directory: ${{ inputs.cargo-toml-folder }}
shell: bash
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/lint-ts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ name: lint-ts

on:
push:
branches: ["main"]
branches:
- main
- release-*
- v*
paths:
- benchmarks/node/**
- node/**
Expand Down
Loading