-
Notifications
You must be signed in to change notification settings - Fork 95
Multi-database support in cluster mode #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+24
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated documentation to reflect multi-database support in Valkey Cluster. - Removed outdated restrictions on `SELECT` and database-related commands. - Clarified that `MIGRATE`, `COUNTKEYSINSLOT`, and `GETKEYSINSLOT` operate within the selected database. - Clarified that `SWAPDB` is disabled in cluster mode to prevent shard inconsistencies. Signed-off-by: xbasel <[email protected]>
Depends on valkey-io/valkey#1671 |
madolson
reviewed
May 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, minor suggestions.
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: xbasel <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: xbasel <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: xbasel <[email protected]>
Signed-off-by: xbasel <[email protected]>
zuiderkwast
reviewed
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Genarally LGTM
zuiderkwast
reviewed
May 23, 2025
Signed-off-by: xbasel <[email protected]>
zuiderkwast
approved these changes
May 26, 2025
Signed-off-by: xbasel <[email protected]>
This reverts commit 43f16ec. Signed-off-by: xbasel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SELECT
and database-related commands.MIGRATE
,COUNTKEYSINSLOT
, andGETKEYSINSLOT
operate within the selected database.SWAPDB
is disabled in cluster mode to prevent shard inconsistencies.