Skip to content

Conversation

xbasel
Copy link
Member

@xbasel xbasel commented Mar 3, 2025

  • Updated documentation to reflect multi-database support in Valkey Cluster.
  • Removed outdated restrictions on SELECT and database-related commands.
  • Clarified that MIGRATE, COUNTKEYSINSLOT, and GETKEYSINSLOT operate within the selected database.
  • Clarified that SWAPDB is disabled in cluster mode to prevent shard inconsistencies.

- Updated documentation to reflect multi-database support in Valkey Cluster.
- Removed outdated restrictions on `SELECT` and database-related commands.
- Clarified that `MIGRATE`, `COUNTKEYSINSLOT`, and `GETKEYSINSLOT` operate within the selected database.
- Clarified that `SWAPDB` is disabled in cluster mode to prevent shard inconsistencies.

Signed-off-by: xbasel <[email protected]>
@xbasel xbasel self-assigned this Mar 3, 2025
@xbasel xbasel added the documentation Improvements or additions to documentation label Mar 3, 2025
@xbasel
Copy link
Member Author

xbasel commented Mar 3, 2025

Depends on valkey-io/valkey#1671
Fixes: valkey-io/valkey#1319

Copy link
Member

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, minor suggestions.

xbasel and others added 4 commits May 9, 2025 22:48
Co-authored-by: Madelyn Olson <[email protected]>
Signed-off-by: xbasel <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]>
Signed-off-by: xbasel <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]>
Signed-off-by: xbasel <[email protected]>
Signed-off-by: xbasel <[email protected]>
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genarally LGTM

@xbasel xbasel requested a review from zuiderkwast May 26, 2025 09:29
Signed-off-by: xbasel <[email protected]>
xbasel added 2 commits May 26, 2025 13:29
Signed-off-by: xbasel <[email protected]>
This reverts commit 43f16ec.

Signed-off-by: xbasel <[email protected]>
@zuiderkwast zuiderkwast merged commit 8f9f504 into valkey-io:main May 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants