Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey, I wanted to see if we could update this library to Ink 6 (+ React 19) to unblock updating ink-ui (vadimdemedes/ink-ui#15).
React 19 introduced synchronous effect flushing, which changes when
useEffectruns. In Ink's debug mode,writeToStderr()immediately writes to stdout withthis.lastOutput(reference), but due to React 19's synchronous timing,this.lastOutputmay be empty when the effect runs, causing an empty string to be written to stdout. This is a transient state that doesn't last more than a frame in real cases but one of the tests failed for this reason.I opted for just filtering the empty stdout in the failing test, but let me know if you have other plans to fix this.
CC @sindresorhus